Fix deprecation warning, fix private method `gsub' called for nil:NilClass error on 1.8.7 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'rdoc/task' (in RDoc 2.4.2+)' instead.
at ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/rdoctask.rb
| it 'should tolerate oddly formed URIs' do | ||
| destination_url = 'https://foo.com/path/to/page?&sort=date_received.DESC' | ||
|
|
||
| client.logout_url(destination_url) |
There was a problem hiding this comment.
what is the expected output of this call?
There was a problem hiding this comment.
Its not too relevant, at least for this bug - the code throws an error, or doesn't. Happy to contribute other test coverage that targets the method in a separate pr
There was a problem hiding this comment.
Ugh, it's been three years and the underlying bug is still present - https://github.com/rubycas/rubycas-client/blob/master/lib/casclient/client.rb#L286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was rubycas/rubycas-client-rails#20
With certain URIs, it's possible to have a blank key, causing a private method `gsub' called for nil:NilClass error on 1.8.7