-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update config.example.yml #12
Comments
Take a look at line 38 in http://github.com/gunark/rubycas-server/blob/master/lib/casserver/conf.rb We check whether the authenticator config is an array and convert if required. Requiring users to add a tiny dash in front of their authenticator settings in their config.yml might be a bit too esoteric. Unless your intimately familiar with YAML, it's not at all obvious that - means "array". The goal is to make the initial set up process for new users as easy as possible, so in the interest of simplicity I'd rather allow users to enter a non-array value for their authenticator. |
I thought it was an intentional change, so I was changing the config. Thanks for your reply. |
Github is refusing to let me apply patches right now... something about the repository being migrated to a new server. I'll get this stuff applied ASAP. Thanks for all the hard work. |
has this been updated as I wasted plenty of time finding out the config requires an extra - in order for my server not to crash with 'premature end of script' errors. thanks. |
Ah crap I must have closed this without actually pulling in the fix. Should be there now. Thanks for the reminder. |
see:
http://github.com/godfat/rubycas-server/commit/addb581e6c8c9161dc55df452c551e1fdfd9241d
Since
$CONF.authenticator
is always read as an array:http://github.com/gunark/rubycas-server/blob/01238483a9691dcf0deb0468ca8b41a7603e7071/lib/casserver/controllers.rb#L136
The text was updated successfully, but these errors were encountered: