-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1741] Generate past court reports from past court date #2095
Merged
compwron
merged 5 commits into
rubyforgood:main
from
rhian-cs:1741-generate-past-court-report-from-past-court-date
Jun 3, 2021
Merged
[#1741] Generate past court reports from past court date #2095
compwron
merged 5 commits into
rubyforgood:main
from
rhian-cs:1741-generate-past-court-report-from-past-court-date
Jun 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compwron
approved these changes
Jun 3, 2021
class PastCourtDate < ApplicationRecord | ||
belongs_to :casa_case | ||
|
||
has_many :case_court_mandates | ||
belongs_to :hearing_type, optional: true | ||
belongs_to :judge, optional: true | ||
|
||
DOCX_TEMPLATE_PATH = "app/documents/templates/default_past_court_date_template.docx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style note: prefer to use Rails.root.join
describe "methods" do | ||
let(:past_court_date) { build_stubbed(:past_court_date) } | ||
|
||
pending "#associated_reports" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please implement the pending tests also
👏🏼 🙌🏼 💪 ✨ 📈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #1741
What changed, and why?
Admins, supervisors and case volunteers are now able to download a .docx report of a given past court date.
How will this affect user permissions?
The permissions to download the .docx reports are the same as the ones to see the past court date itself (since it is the same action in the controller).
How is this tested? (please write tests!) 💖💪
Automated specs:
Manual testing:
Screenshots please :)
A new button is now present at the past court date page
Desktop view:
Mobile view:
Generated document:
Feelings gif (optional)
What it felt like to be forced to use Microsoft Word to generate the template:
Just kidding ;)
No errors occurred but I had to use someone else's computer to use MS Word