Allows volunteer assignment on case creation #5880

kenny-luong · 2024-07-04T18:21:29Z

What github issue is this PR for, if any?

Resolves #5757

What changed, and why?

Major Changes

Added an "Assign a new volunteer" dropdown to /casa_cases/new
Updated controller to assign the volunteer after the case is saved

Minor Changes

Updated text for volunteer assignment /casa_cases/:id/edit to "Assign a Volunteer to Case"
Updated styling for volunteer assignment in /casa_cases/:id/edit to include the caret icon

How is this tested? (please write tests!) 💖💪

Added specs to test the flow and updated existing specs to support this

Manual testing includes:

Creating a new case and assigning a volunteer
Creating a new case without assigning a volunteer

Screenshots please :)

kenny-luong · 2024-07-04T18:22:11Z

@wandergithub Tagging you as you requested

elasticspoon · 2024-07-05T01:53:52Z

app/controllers/casa_cases_controller.rb

We should do this as nested attributes. It will provide additional ACID guarantees and the implementation will be simpler.

You are gonna want to:

allow cases to accept nested attributes for case assignments

set up nested fields in the views

permit those parameters

after that ActiveRecord save, update, etc will handle all the creation and updates for you.

Sorry for the long turnaround time. Was out of town.

All done now.

elasticspoon · 2024-07-06T17:44:47Z

@kenny-luong feel free to pop in for office hours tuesdays https://discord.gg/qJcw2RZH8Q at 8EST if you feel stuck.

kenny-luong · 2024-07-06T21:37:55Z

@kenny-luong feel free to pop in for office hours tuesdays https://discord.gg/qJcw2RZH8Q at 8EST if you feel stuck.

That's good to know, thank you. I'll make the changes as soon as I get back home. 👍

elasticspoon

This looks way simpler with the nested attributes.

I also think we could simplify how this is test a bit. I think you could test basically all the functionality in a single system test:

make a new case
select a volunteer during that case creation
check that on the show page for the case that volunteer is assigned

I think that will result in less tests to maintain an it covers the most critical workflow of the whole feature.

elasticspoon · 2024-07-10T23:49:07Z

app/controllers/casa_cases_controller.rb

-
+    create_params = casa_case_params
+    create_params = create_params.except(:court_dates_attributes) if court_date_unknown?
+    create_params = create_params.except(:case_assignments_attributes) unless assigned_volunteer?


Why do we need to exclude case assignment attributes in this situation? Is some issue created if we don't?

It might be a symptom of another issue but if you don't exclude these attributes (case assignment and court date), and they are left blank on the form, there will be an error.

Though I think this can be fixed by updating the model to do something like this

class CasaCase # ... accepts_nested_attributes_for :case_assignments, reject_if: proc { |attributes| attributes['volunteer_id'].blank? } # ... end

I grabbed this from here: https://stackoverflow.com/questions/56096562/how-to-do-optional-nested-forms-with-form-for-in-rails-5

elasticspoon · 2024-07-10T23:50:53Z

app/views/casa_cases/_form.html.erb

+              <%= caf.select :volunteer_id,
+                             @casa_case.unassigned_volunteers.map { |v| [v.display_name, v.id] },
+                             prompt: "Please select a volunteer" %>


You could use collection_select for this

https://apidock.com/rails/v5.2.3/ActionView/Helpers/FormOptionsHelper/collection_select

kenny-luong · 2024-07-11T01:00:18Z

This looks way simpler with the nested attributes.

I also think we could simplify how this is test a bit. I think you could test basically all the functionality in a single system test:

make a new case select a volunteer during that case creation check that on the show page for the case that volunteer is assigned

I think that will result in less tests to maintain an it covers the most critical workflow of the whole feature.

I've updated one of the existing system tests to account for this. Let me know if that is not sufficient.

elasticspoon

Looks good to me! Nice job! ❤️

elasticspoon · 2024-07-13T19:31:05Z

app/controllers/casa_cases_controller.rb

+    create_params = casa_case_params
+    create_params = create_params.except(:court_dates_attributes) if court_date_unknown?
    create_params.except(:empty_court_date)


Suggested change

create_params = casa_case_params

create_params = create_params.except(:court_dates_attributes) if court_date_unknown?

create_params.except(:empty_court_date)

create_params = casa_case_params.except(:empty_court_date)

create_params = create_params.except(:court_dates_attributes) if court_date_unknown?

🤷‍♂️

Might have been a bad call on my part since now the tests are failing 🙂

Ah yeah this is just an ordering problem. I'll fix it now. No big deal.

I've reverted the commit.

elasticspoon · 2024-07-13T19:31:11Z

app/models/casa_case.rb

@@ -48,6 +48,7 @@ class CasaCase < ApplicationRecord
  accepts_nested_attributes_for :casa_case_contact_types
  accepts_nested_attributes_for :court_dates
  accepts_nested_attributes_for :volunteers
+  accepts_nested_attributes_for :case_assignments, reject_if: proc { |attributes| attributes["volunteer_id"].blank? }


This makes more sense to me compared to having the if statement at the controller level.

I am not sure which is better

accepts_nested_attributes_for :case_assignments, reject_if: proc { |attributes| attributes["volunteer_id"].blank? } # or accepts_nested_attributes_for :case_assignments, reject_if: :all_blank

Allows volunteer assignemnt on case creation

af6793a

kenny-luong requested review from compwron, FireLemons, littleforest and elasticspoon as code owners July 4, 2024 18:21

github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 erb labels Jul 4, 2024

Kenny Luong added 2 commits July 4, 2024 11:22

Update stlying for casa_cases/id/edit

4330547

linter changes

b80bd25

kenny-luong mentioned this pull request Jul 4, 2024

Improve Volunteer Assignment when creating a new case #5757

Closed

elasticspoon requested changes Jul 5, 2024

View reviewed changes

compwron changed the title ~~Allows volunteer assignemnt on case creation~~ Allows volunteer assignment on case creation Jul 5, 2024

Uses nested attributes for case assignment

094bfa3

elasticspoon reviewed Jul 11, 2024

View reviewed changes

Kenny Luong added 2 commits July 10, 2024 17:44

Updates per PR review

9bf08ff

Updates system test

4fb4b0c

elasticspoon approved these changes Jul 13, 2024

View reviewed changes

kenny-luong force-pushed the 5757/VOLUNTEER-ASSIGNMENT-WHEN-CREATING-A-CASE branch from fe02ec6 to 4fb4b0c Compare July 13, 2024 23:46

elasticspoon merged commit 39ef9cb into rubyforgood:main Jul 16, 2024
34 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allows volunteer assignment on case creation #5880

Allows volunteer assignment on case creation #5880

kenny-luong commented Jul 4, 2024 •

edited

Loading

kenny-luong commented Jul 4, 2024

elasticspoon Jul 5, 2024

kenny-luong Jul 8, 2024

elasticspoon commented Jul 6, 2024

kenny-luong commented Jul 6, 2024

elasticspoon left a comment

elasticspoon Jul 10, 2024

kenny-luong Jul 11, 2024

elasticspoon Jul 10, 2024 •

edited

Loading

kenny-luong commented Jul 11, 2024

elasticspoon left a comment

elasticspoon Jul 13, 2024

elasticspoon Jul 13, 2024

kenny-luong Jul 13, 2024

kenny-luong Jul 13, 2024

elasticspoon Jul 13, 2024

Allows volunteer assignment on case creation #5880

Allows volunteer assignment on case creation #5880

Conversation

kenny-luong commented Jul 4, 2024 • edited Loading

What github issue is this PR for, if any?

What changed, and why?

Major Changes

Minor Changes

How is this tested? (please write tests!) 💖💪

Screenshots please :)

kenny-luong commented Jul 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticspoon commented Jul 6, 2024

kenny-luong commented Jul 6, 2024

elasticspoon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticspoon Jul 10, 2024 • edited Loading

Choose a reason for hiding this comment

kenny-luong commented Jul 11, 2024

elasticspoon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenny-luong commented Jul 4, 2024 •

edited

Loading

elasticspoon Jul 10, 2024 •

edited

Loading