additional characters to be accepted for password #3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
approved these changes
Nov 10, 2023
|
@seagivens lint is failing - can you please fix? Otherwise looks good! |
awwaiid
previously requested changes
Nov 12, 2023
Co-authored-by: Brock Wilcox <awwaiid@thelackthereof.org>
kiranbpatil
reviewed
Nov 27, 2023
| @@ -87,7 +87,7 @@ def formatted_email | |||
| end | |||
|
|
|||
| def password_complexity | |||
| return if password.blank? || password =~ /(?=.*?[#?!@$%^&*-])/ | |||
| return if password.blank? || password =~ /(?=.*?[#?!@$%^&*\-;,.()=+|:])/ | |||
There was a problem hiding this comment.
nit: Can create a password with only (and also one) special character/s.
|
Very very delayed but I think this is good to merge! This slipped between the cracks. |
dorner
approved these changes
Mar 8, 2024
|
@seagivens: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Resolves #3789
Description
expanded the list of special characters that are accepted to satisfy the password strength requirements, as described in Bug #3789
Type of change
How Has This Been Tested?
added new unit tests