Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky dist by county spec #4362

Merged

Conversation

elasticspoon
Copy link
Collaborator

@elasticspoon elasticspoon commented May 16, 2024

Fixes #4338

Spec looked for a certain amount of the value or '25' on the page if the bank was name Bank 125 or Bank 125 the test would fail. (And there was another test that did the same with '50'.)
For example: screenshot_works-for-this-year_2024-05-15-19-44-17 582

Set a unique name to ensure failures will not occur.

Spec looked for a certain amount of the value '50' on the page
if the bank was name Bank 50 or Bank 150 the test would fail.

Set a unique name to ensure failures will not occur.
@elasticspoon elasticspoon force-pushed the fix-flaky-dist-by-county-spec branch from 43e1935 to 32e101a Compare May 16, 2024 02:53
@elasticspoon elasticspoon marked this pull request as ready for review May 16, 2024 02:59
@elasticspoon elasticspoon requested a review from cielf May 16, 2024 02:59
Copy link
Collaborator

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement, tests pass, 👍

@awwaiid awwaiid merged commit b583d7b into rubyforgood:main May 16, 2024
19 checks passed
@elasticspoon elasticspoon deleted the fix-flaky-dist-by-county-spec branch May 16, 2024 23:44
Copy link
Contributor

@elasticspoon: Your PR fix: flaky dist by county spec is part of today's Human Essentials production release: 2024.05.26.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: flaky distributions_by_county_system_spec
2 participants