Improve and fixed guide style code from outdated cmd #5114
Conversation
ryanfox1985
force-pushed
the
improve_outdated_code
branch
3 times, most recently
from
148cbf7
to
f261c79
Compare
|
☔ The latest upstream changes (presumably #5176) made this pull request unmergeable. Please resolve the merge conflicts. |
1 similar comment
|
☔ The latest upstream changes (presumably #5176) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@ryanfox1985 my apologies, I didn't even know about this PR, and it looks like my recent merge stomped on it as well. It does seem most of these could stay with a small update on the same sort of method extraction you did that was in the recent merged commit. I'd love to get @indirect's opinion on these changes. The project already uses rubocop to monitor style issues, and I don't feel like I have the history with the codebase to have a valuable opinion on making these changes. (Part of me doesn't want these changes due to disruption into the git history on the various lines). |
ryanfox1985
force-pushed
the
improve_outdated_code
branch
from
f261c79
to
a68f526
Compare
|
@chrismo rebased. |
|
@chrismo r? |
|
xD |
|
@chrismo A part of combine the dependency array and sort one time, I improve calculate filter_options_patch the old version is checking the three variables for each gem. |
|
@bundlerbot r+ |
|
📌 Commit a68f526 has been approved by |
Improve and fixed guide style code from outdated cmd Hi, I separate these part from this PR #5058. Regards.
|
☀️ Test successful - status-travis |
Hi,
I separate these part from this PR #5058.
Regards.