Merge GemVersionPromoter into outdated cmd #5058
Conversation
ryanfox1985
force-pushed
the
merge_gemversion
branch
from
b69bc98
to
ae9c22f
Compare
|
thx - i actually had started working on this locally, i'm not sure some of these changes are going to be necessary, but we'll see -- here's my new PR in progress now: #5061. |
ryanfox1985
force-pushed
the
merge_gemversion
branch
from
ae9c22f
to
a672223
Compare
|
@chrismo, If you want I can apply your renames of the input variables [patch, minor, major]. |
|
@chrismo, can you do the review here? Regards. |
|
☔ The latest upstream changes (presumably #5061) made this pull request unmergeable. Please resolve the merge conflicts. |
ryanfox1985
force-pushed
the
merge_gemversion
branch
from
a672223
to
b7798e5
Compare
ryanfox1985
force-pushed
the
merge_gemversion
branch
from
b7798e5
to
b1a7476
Compare
|
I think that I need to fix one test and rollback the changes on |
|
@ryanfox1985 I ended up taking care of this in #5061, unless you see something there I missed, we can close yours. |
| end | ||
|
|
||
| if options["filter-major"] || options["filter-minor"] || options["filter-patch"] | ||
| active_spec = Bundler.definition.gem_version_promoter.sort_versions(dependency, spec_groups).last |
|
☔ The latest upstream changes (presumably #5176) made this pull request unmergeable. Please resolve the merge conflicts. |
1 similar comment
|
☔ The latest upstream changes (presumably #5176) made this pull request unmergeable. Please resolve the merge conflicts. |
|
closing since this was taken care of in #5061 |
Improve and fixed guide style code from outdated cmd Hi, I separate these part from this PR #5058. Regards.
Hi I created this PR according with:
#4841
Regards.