Include bundler.gemspec in the gem because warbler breaks w/o it #6195
Conversation
f06405 caused a regression with warbler, described in rubygems#6165
|
Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack. For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide |
|
What is warbler? It shouldn't be necessary to ship the gemspec, as when the gem is installed the real gemspec that RubyGems uses is installed separately. |
|
Warbler is one of central packaging tool of JRuby. It needs to gemspec file for packaging to war file. 1.15 ships with gemspec file, but 1.16 is not. It seems to breaking changes. I hope to merge this pull request and help JRuby users. |
|
@bundlerbot r+ |
|
📌 Commit 284a9d6 has been approved by |
Include bundler.gemspec in the gem because warbler breaks w/o it f06405 caused a regression with warbler, described in #6165 and jruby/warbler#421 If the fix is ok, it should probably be cherry-picked to 1-16-stable. ### What was the end-user problem that led to this PR? Upgrading from bundler v1.15.x to v1.16.0 causes warbler to break/abort with error. ### What was your diagnosis of the problem? 1. error message from warbler: missing file 2. see why file is missing 3. google to see if it's just me 😄 ### What is your fix for the problem, implemented in this PR? Put the missing (from warblers point of view at least) back. ### Why did you choose this fix out of the possible options? Seems easier than to fix warbler.
|
☀️ Test successful - status-travis |
Include bundler.gemspec in the gem because warbler breaks w/o it f06405 caused a regression with warbler, described in rubygems#6165 and jruby/warbler#421 If the fix is ok, it should probably be cherry-picked to 1-16-stable. ### What was the end-user problem that led to this PR? Upgrading from bundler v1.15.x to v1.16.0 causes warbler to break/abort with error. ### What was your diagnosis of the problem? 1. error message from warbler: missing file 2. see why file is missing 3. google to see if it's just me 😄 ### What is your fix for the problem, implemented in this PR? Put the missing (from warblers point of view at least) back. ### Why did you choose this fix out of the possible options? Seems easier than to fix warbler.
f06405 caused a regression with warbler, described in #6165 and jruby/warbler#421
If the fix is ok, it should probably be cherry-picked to 1-16-stable.
What was the end-user problem that led to this PR?
Upgrading from bundler v1.15.x to v1.16.0 causes warbler to break/abort with error.
What was your diagnosis of the problem?
What is your fix for the problem, implemented in this PR?
Put the missing (from warblers point of view at least) back.
Why did you choose this fix out of the possible options?
Seems easier than to fix warbler.