Respect auth set in upstream host uri #317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some private gem repos like Gemfury use Basic Auth with just an api key rather than a username and password (ex.
https://<api_key>@gem.fury.io/<repo>
). Setting up upstream mirroring for this case should work as described in #247, but becauseFaraday
does not respect Basic Authentication being passed in the URL unless its of theuser:pass
format, some additional logic was needed to support this use case.Tasks:
I will abide by the code of conduct.