Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration: support GEMSTASH_CONFIG environment variable #373

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Sep 29, 2023

Some gemstash configurations don't have a /home/gemstash directory (e.g. minimal Docker installations), and prefer to store their Gemstash configuration elsewhere (e.g. in a system-wide location such as /etc/gemstash/config.yml). Today, such use-cases require every Gemstash command to be accompanied by the --config-file CLI option, and forgetting to do so causes Gemstash to use its default settings.

This PR resolves #369, smoothing the wrinkles for this use-case, by supporting defining the path to one's configuration in the GEMSTASH_CONFIG environment variable.

@kyrofa kyrofa force-pushed the feature/369/support-environment-variable-for-config branch from 00c2d95 to 6b061c3 Compare September 29, 2023 18:15
Some gemstash configurations don't have a `/home/gemstash` directory
(e.g. minimal Docker installations), and prefer to store their Gemstash
configuration elsewhere (e.g. in a system-wide location such as
`/etc/gemstash/config.yml`). Today, such use-cases require every
Gemstash command to be accompanied by the `--config-file` CLI option,
and forgetting to do so causes Gemstash to use its default settings.

Smooth the wrinkles for this use-case by supporting defining the path to
one's configuration in the `GEMSTASH_CONFIG` environment variable.

Resolve rubygems#369

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa kyrofa force-pushed the feature/369/support-environment-variable-for-config branch from 6b061c3 to 4728a6a Compare September 29, 2023 18:20
@olleolleolle
Copy link
Member

Yes! Thank you!

♥️ 💛 💚 💙 💜

@olleolleolle olleolleolle merged commit 635be25 into rubygems:main Sep 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support config file in /etc
3 participants