configuration: support GEMSTASH_CONFIG environment variable #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrofa
force-pushed
the
feature/369/support-environment-variable-for-config
branch
from
00c2d95
to
6b061c3
Compare
Some gemstash configurations don't have a `/home/gemstash` directory (e.g. minimal Docker installations), and prefer to store their Gemstash configuration elsewhere (e.g. in a system-wide location such as `/etc/gemstash/config.yml`). Today, such use-cases require every Gemstash command to be accompanied by the `--config-file` CLI option, and forgetting to do so causes Gemstash to use its default settings. Smooth the wrinkles for this use-case by supporting defining the path to one's configuration in the `GEMSTASH_CONFIG` environment variable. Resolve rubygems#369 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
kyrofa
force-pushed
the
feature/369/support-environment-variable-for-config
branch
from
6b061c3
to
4728a6a
Compare
indirect
approved these changes
Sep 29, 2023
|
Yes! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some gemstash configurations don't have a
/home/gemstashdirectory (e.g. minimal Docker installations), and prefer to store their Gemstash configuration elsewhere (e.g. in a system-wide location such as/etc/gemstash/config.yml). Today, such use-cases require every Gemstash command to be accompanied by the--config-fileCLI option, and forgetting to do so causes Gemstash to use its default settings.This PR resolves #369, smoothing the wrinkles for this use-case, by supporting defining the path to one's configuration in the
GEMSTASH_CONFIGenvironment variable.