Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to Ubuntu 22.04. #3188

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Update CI to Ubuntu 22.04. #3188

merged 1 commit into from
Jan 17, 2023

Conversation

simi
Copy link
Member

@simi simi commented Aug 20, 2022

ℹ️ Originally I tried to upgrade to Ubuntu 22.04, but there were problems with OpenSSL 3.0. It seems some API was removed with proper replacement. I have asked at ruby/openssl#480 (comment) for more info.

For now, we can (at least) migrate to Ubuntu 20.04, since Ubuntu 18.04 is deprecated for GitHub Actions.

https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/

@simi simi changed the title Update CI to Ubuntu 22.04. Update CI to Ubuntu 20.04. Aug 20, 2022
@simi simi marked this pull request as ready for review August 20, 2022 22:21
@simi simi marked this pull request as draft August 21, 2022 09:28
@simi simi changed the title Update CI to Ubuntu 20.04. Update CI to Ubuntu 22.04 and support OpenSSL 3. Aug 21, 2022
@simi simi mentioned this pull request Aug 21, 2022
@simi
Copy link
Member Author

simi commented Aug 21, 2022

ℹ️ blocked until new Alpine release with OpenSSL 3

@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #3188 (ca879ad) into master (a293631) will decrease coverage by 0.38%.
The diff coverage is n/a.

❗ Current head ca879ad differs from pull request most recent head 4be2cce. Consider uploading reports for the commit 4be2cce to get more accurate results

@@            Coverage Diff             @@
##           master    #3188      +/-   ##
==========================================
- Coverage   98.58%   98.19%   -0.39%     
==========================================
  Files         113      110       -3     
  Lines        3384     3320      -64     
==========================================
- Hits         3336     3260      -76     
- Misses         48       60      +12     
Impacted Files Coverage Δ
lib/fastly.rb 69.56% <0.00%> (-30.44%) ⬇️
app/controllers/api/v1/api_keys_controller.rb 94.11% <0.00%> (-5.89%) ⬇️
app/models/concerns/rubygem_searchable.rb 94.44% <0.00%> (-5.56%) ⬇️
app/models/user.rb 100.00% <0.00%> (ø)
lib/elastic_searcher.rb 100.00% <0.00%> (ø)
app/controllers/sessions_controller.rb 100.00% <0.00%> (ø)
app/controllers/settings_controller.rb 100.00% <0.00%> (ø)
app/models/webauthn_credential.rb
app/models/concerns/user_webauthn_methods.rb
app/controllers/webauthn_credentials_controller.rb

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simi simi marked this pull request as ready for review September 10, 2022 21:30
@simi
Copy link
Member Author

simi commented Sep 10, 2022

ℹ️ last OpenSSL problem was fixed at ruby/openssl#541 and is included in latest release. But I'm not still sure if there is any value in this PR. 🤔

@jenshenny
Copy link
Member

@simi would you be able to elaborate? Is it because you rather wait for the new Alpine release to upgrade both prod and ci

@simi
Copy link
Member Author

simi commented Sep 12, 2022

I'm not sure it is worth it to add openssl into Gemfile manually. We will get latest openssl with next Ruby release as well (ruby/ruby#6337). IMHO it is ok to wait for that and move to Ubuntu 22.04 at CI with next Ruby upgrade. WDYT?

@jenshenny
Copy link
Member

Gotcha! Thanks for providing that info, I think we can wait for the next Ruby release then too 👍

@sonalkr132
Copy link
Member

Unless this resolves a security issue in prod, we shouldn't have to update.

@simi
Copy link
Member Author

simi commented Jan 16, 2023

I'll strip down this PR to just update the CI runners. OpenSSL would get pulled in in https://github.com/rubygems/rubygems.org/pull/3337/files (on both sides, into app as default gem and also into docker container using Alpine 3.17 if I understand it well).

Btw. we're already locked at OpenSSL 3.0.1 gem.

openssl (3.0.1)

@simi simi changed the title Update CI to Ubuntu 22.04 and support OpenSSL 3. Update CI to Ubuntu 22.04. Jan 16, 2023
@simi simi requested a review from hsbt January 16, 2023 23:25
@simi simi merged commit 2ed6d6c into master Jan 17, 2023
@simi simi deleted the ci-22-04-ubuntu branch January 17, 2023 23:23
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to staging January 17, 2023 23:33 Inactive
@hsbt
Copy link
Member

hsbt commented Jan 18, 2023

👍 There is only concern about Ubuntu 22.04 with Ruby 3.0. The current ruby version is 3.1, There is no reason to stay Ubuntu 20.04.

@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to production January 18, 2023 15:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants