-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Japanese translation #4779
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4779 +/- ##
==========================================
+ Coverage 97.00% 97.06% +0.05%
==========================================
Files 397 399 +2
Lines 8428 8444 +16
==========================================
+ Hits 8176 8196 +20
+ Misses 252 248 -4 ☔ View full report in Codecov by Sentry. |
66ae739
to
53e6b29
Compare
* config/locales/ja.yml: Update Japanese translation for 64be113. Note that the message at downloads_amount is translated in ``improved the translation into Japanese rubygems#4149''[1]. [1] rubygems#4149
* config/locales/ja.yml: Translate on/off into Japanese. These are not translated in rubygems#3998.
* config/locales/ja.yml (notifiers.show.info): Delete zero-width space in Japanese message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing. @hsbt can you review as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I'll save approval for someone that can actually read Japanese. I really appreciate the help!
Co-authored-by: OKURA Masafumi <masafumi.o1988@gmail.com>
Hello @okuramasafumi, thank you for your suggestions. I applied them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review, @okuramasafumi.
I wanted to approve this PR but GitHub didn't allow me, so I say "Great work!" |
Thanks all for nice co-operation in here. |
👍 |
Hello RubyGems,
This updates Japanese translation.
Each commit adds changes corresponding to those made to the respective English file (
en.yml
), as in the commit subject.Thank you,
gemmaro.
TODOs to be ready for review.