Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Japanese translation #4779

Merged
merged 21 commits into from
Jun 15, 2024
Merged

Update Japanese translation #4779

merged 21 commits into from
Jun 15, 2024

Conversation

gemmaro
Copy link
Contributor

@gemmaro gemmaro commented Jun 9, 2024

Hello RubyGems,

This updates Japanese translation.
Each commit adds changes corresponding to those made to the respective English file (en.yml), as in the commit subject.

Thank you,
gemmaro.


TODOs to be ready for review.

  • Self-check the translation by looking at the way the messages are called.

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (331f253) to head (dc3085d).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4779      +/-   ##
==========================================
+ Coverage   97.00%   97.06%   +0.05%     
==========================================
  Files         397      399       +2     
  Lines        8428     8444      +16     
==========================================
+ Hits         8176     8196      +20     
+ Misses        252      248       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gemmaro gemmaro force-pushed the up/ja branch 2 times, most recently from 66ae739 to 53e6b29 Compare June 11, 2024 10:30
@gemmaro gemmaro marked this pull request as ready for review June 11, 2024 10:30
Copy link
Member

@simi simi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. @hsbt can you review as well?

Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I'll save approval for someone that can actually read Japanese. I really appreciate the help!

config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
Co-authored-by: OKURA Masafumi <masafumi.o1988@gmail.com>
@gemmaro
Copy link
Contributor Author

gemmaro commented Jun 15, 2024

Hello @okuramasafumi, thank you for your suggestions. I applied them.

Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review, @okuramasafumi.

@okuramasafumi
Copy link
Contributor

I wanted to approve this PR but GitHub didn't allow me, so I say "Great work!"

@simi simi merged commit 97a6a5d into rubygems:master Jun 15, 2024
17 checks passed
@simi
Copy link
Member

simi commented Jun 15, 2024

Thanks all for nice co-operation in here.

@gemmaro gemmaro deleted the up/ja branch June 15, 2024 21:12
@hsbt
Copy link
Member

hsbt commented Jun 17, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants