Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lockfile generation and deprecate Definition#lock with explicit lockfile #7047

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Refactor lockfile generation and deprecate Definition#lock with explicit lockfile #7047

merged 7 commits into from
Jan 30, 2024

Commits on Jan 26, 2024

  1. Remove unused parameter

    @deivid-rodriguez
    deivid-rodriguez committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    085eda7 View commit details
    Browse the repository at this point in the history

  2. Refactor lockfile generation

    @deivid-rodriguez
    deivid-rodriguez committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    6a0c03c View commit details
    Browse the repository at this point in the history

  3. Move subject to top level context

    @deivid-rodriguez
    deivid-rodriguez committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    331c415 View commit details
    Browse the repository at this point in the history

  4. Fix incorrect 4th parameter to Definition.new

    @deivid-rodriguez
    deivid-rodriguez committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    54948e4 View commit details
    Browse the repository at this point in the history

  5. Run definition specs in an isolated location 

    And consistently pass Pathname's to `Definition.new` like production
code does.
    @deivid-rodriguez
    deivid-rodriguez committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    660def5 View commit details
    Browse the repository at this point in the history

  6. Use deprecation helper for deprecation warning

    @deivid-rodriguez
    deivid-rodriguez committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d1963bf View commit details
    Browse the repository at this point in the history

  7. Improve assertion 

    Co-authored-by: Martin Emde <martin.emde@gmail.com>
    @deivid-rodriguez @martinemde
    deivid-rodriguez and martinemde committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    7f2f2b8 View commit details
    Browse the repository at this point in the history