Do not use `configs' which is used by RubyMotion internal #143

Watson1978 · 2012-09-19T15:38:36Z

`configs' will be removed with next update (v1.24).

supermarin · 2012-09-19T21:29:17Z

It seems like it crashes the specs:

[master ✔] ➜ rake spec output=test_unit                                                                                
rake aborted!
undefined method `setup_blocks' for #<Motion::Project::Config:0x007fd78b628f58>

(See full trace by running task with --trace)

Watson1978 · 2012-09-20T00:22:58Z

Oh, sorry. `setup_blocks' method will be added by v1.24.
RubyMotion v1.24 is not release yet. but it will be release soon.

supermarin · 2012-09-20T11:31:27Z

Okay sure,. Is there a way we can add a check if the RM version is >= 1.24 and based on that use the appropriate accessor?

Watson1978 · 2012-09-20T12:04:16Z

Which one do you like?

To detect version number, you could parse the Motion::Version
If setup_blocks will raise exception, you would call configs's method

diff --git a/lib/bubble-wrap/ext/motion_project_app.rb b/lib/bubble-wrap/ext/motion_project_app.rb
index 28e8f24..1d303f9 100644
--- a/lib/bubble-wrap/ext/motion_project_app.rb
+++ b/lib/bubble-wrap/ext/motion_project_app.rb
@@ -11,8 +11,12 @@ module BubbleWrap
               app.frameworks = ::BubbleWrap::Requirement.frameworks(app.frameworks)
               block.call(app) unless block.nil?
             end
-            configs.each_value &bw_config
-            config.validate
+            begin
+              config.setup_blocks << bw_config
+            rescue
+              configs.each_value &bw_config
+              config.validate
+            end
           end
           alias :setup_without_bubblewrap :setup
           alias :setup :setup_with_bubblewrap

New BubbleWrap version would support only RubyMotion >= 1.24

I think that No.3 is best select :)

supermarin · 2012-09-20T12:12:26Z

I would say option 2 + a warning to the user.
Some newer RM versions had introduced some bugs, and most likely some production apps are sticked to a specific RM version (an older one).

Let's see what the others think, but for now, my suggestion would be something like:

begin
  config.setup_blocks << bw_config
rescue
  NSLog "BW: It seems like you're running an older RubyMotion version than 1.24.
  Please run `sudo motion update` to remove this warning."
  configs.each_value &bw_config
  config.validate
end

Watson1978 · 2012-09-20T12:29:07Z

OK. Whenever you think that anyone will not have to downgrade, you could modify it :)
I will close this request at once.

Thanks :)

supermarin · 2012-09-20T14:32:28Z

I'll reopen this one until we get it fixed :)

Currently, the specs are failing with the iOS6 SDK, so I can't get it tested/merged.
Will close it when we get the proper specs.

michael-erasmus · 2012-09-20T16:55:04Z

Is this related to the error I'm getting?

I just update to the latest RubyMotion and BubbleWrap. This happens when I run rake:

undefined local variable or method `configs' for Motion::Project::App:Class
/Users/developer/.rvm/gems/ruby-1.9.3-p194@ios/gems/bubble-wrap-1.1.3/lib/bubble-wrap/ext/motion_project_app.rb:14:in `setup_with_bubblewrap'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@ios/gems/sugarcube-0.8.2/lib/sugarcube.rb:6:in `<top (required)>'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@ios/gems/bundler-1.1.5/lib/bundler/runtime.rb:68:in `require'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@ios/gems/bundler-1.1.5/lib/bundler/runtime.rb:68:in `block (2 levels) in require'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@ios/gems/bundler-1.1.5/lib/bundler/runtime.rb:66:in `each'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@ios/gems/bundler-1.1.5/lib/bundler/runtime.rb:66:in `block in require'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@ios/gems/bundler-1.1.5/lib/bundler/runtime.rb:55:in `each'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@ios/gems/bundler-1.1.5/lib/bundler/runtime.rb:55:in `require'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@ios/gems/bundler-1.1.5/lib/bundler.rb:119:in `require'
/Users/developer/Source/22Seven/ios/Rakefile:5:in `<top (required)>'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/rake_module.rb:25:in `load'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/rake_module.rb:25:in `load_rakefile'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:501:in `raw_load_rakefile'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:82:in `block in load_rakefile'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:133:in `standard_exception_handling'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:81:in `load_rakefile'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:65:in `block in run'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:133:in `standard_exception_handling'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:63:in `run'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/bin/rake:33:in `<top (required)>'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@global/bin/rake:19:in `load'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@global/bin/rake:19:in `<main>'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@ios/bin/ruby_noexec_wrapper:14:in `eval'
/Users/developer/.rvm/gems/ruby-1.9.3-p194@ios/bin/ruby_noexec_wrapper:14:in `<main>'

clayallsopp · 2012-09-20T16:56:59Z

@michael-erasmus yes

michael-erasmus · 2012-09-20T17:00:39Z

It works fine when change

configs.each_value &bw_config

To

config.setup_blocks << bw_config

In

bubble-wrap-1.1.3/lib/bubble-wrap/ext/motion_project_app.rb

So that is a quickfix for anyone getting this and who still needs to work today :)

DougPuchalski · 2012-09-20T18:39:30Z

@michael-erasmus Thanks for the patch

dmarkow · 2012-09-20T18:54:07Z

@mneorr Unfortunately, once you update to RubyMotion 1.24, the specs won't run because of this config vs configs issue (I realize that once that's fixed, there are still other issues preventing the specs from running).

I think we should push this change using the recommendation of Option 2 + a warning.

mikesax · 2012-09-20T18:56:00Z

RubyMotion 1.24 fails to build projects that include BubbleWrap for me.

michael-erasmus's patch fixes it. (thanks!)

dmarkow · 2012-09-20T19:10:12Z

Now that I think about it, I think Option 3 is actually better (just don't support < 1.24). If someone has their app locked to an older version in production, they should also have it locked to an older version of BW too. Ideally, RubyMotion would have properly deprecated the configs removal, giving users a period of time to transition and use either one.

Since RubyMotion is still very young and new, and changing all the time, supporting older versions doesn't seem to make a lot of sense. I'd hate to see BW get littered with dozens of conditional statements and/or rescue blocks (for example, @Watson1978's other pull request to add _spec to the end of the test suite name would need a conditional based on the version of RubyMotion being used).

Thoughts? I'd like to get this fixed ASAP so we can push an updated gem; in the mean time, no one can use the current BW gem on RubyMotion 1.24

DougPuchalski · 2012-09-20T19:21:36Z

@dmarkow Agreed on #3. Users should lock to a version/commit.

As more apps go into production, it'll be important too keep branches that work with a particular version of RubyMine/SDK around. Master should really only be for development work I think and should keep moving.

siuying · 2012-09-21T05:45:20Z

I'll merge this first for that 1.24 is released.

Do not use `configs' which is used by RubyMotion internal

supermarin · 2012-09-21T08:21:11Z

@dmarkow I've posted another one on #144, the failure reason was different than this one :)

It seems like the iOS5 - 6 transition had some problems with RM compiler.
After updating RM it seems like it's working fine.

siuying · 2012-09-26T16:29:54Z

bubble-wrap 1.1.4 with this fix is released.

Do not use `configs' which is used by RubyMotion internal

b158e21

Watson1978 closed this Sep 20, 2012

supermarin reopened this Sep 20, 2012

supermarin closed this Sep 20, 2012

supermarin reopened this Sep 20, 2012

This was referenced Sep 20, 2012

add the `_spec' into App.identifier #146

Merged

Refactored HTTP request type method definitions #3

Closed

siuying added a commit that referenced this pull request Sep 21, 2012

Merge pull request #143 from Watson1978/configs

4e75e84

Do not use `configs' which is used by RubyMotion internal

siuying merged commit 4e75e84 into rubymotion-community:master Sep 21, 2012

siuying added a commit that referenced this pull request Sep 21, 2012

Add checks for minimum supported RubyMotion version (Refer #143)

ce7ae7c

siuying mentioned this pull request Sep 21, 2012

Add checks for minimum supported RubyMotion version (Refer #143) #147

Closed

siuying mentioned this pull request Sep 21, 2012

BW breaks latest version of motion? #148

Closed

siuying added a commit that referenced this pull request Sep 25, 2012

Add checks for minimum supported RubyMotion version (Refer #143)

c210f56

andyw8 mentioned this pull request Sep 25, 2012

Broken for RubyMotion 1.24 clayallsopp/formotion#37

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not use `configs' which is used by RubyMotion internal #143

Do not use `configs' which is used by RubyMotion internal #143

Watson1978 commented Sep 19, 2012

supermarin commented Sep 19, 2012

Watson1978 commented Sep 20, 2012

supermarin commented Sep 20, 2012

Watson1978 commented Sep 20, 2012

supermarin commented Sep 20, 2012

Watson1978 commented Sep 20, 2012

supermarin commented Sep 20, 2012

michael-erasmus commented Sep 20, 2012

clayallsopp commented Sep 20, 2012

michael-erasmus commented Sep 20, 2012

DougPuchalski commented Sep 20, 2012

dmarkow commented Sep 20, 2012

mikesax commented Sep 20, 2012

dmarkow commented Sep 20, 2012

DougPuchalski commented Sep 20, 2012

siuying commented Sep 21, 2012

supermarin commented Sep 21, 2012

siuying commented Sep 26, 2012

Do not use `configs' which is used by RubyMotion internal #143

Do not use `configs' which is used by RubyMotion internal #143

Conversation

Watson1978 commented Sep 19, 2012

supermarin commented Sep 19, 2012

Watson1978 commented Sep 20, 2012

supermarin commented Sep 20, 2012

Watson1978 commented Sep 20, 2012

supermarin commented Sep 20, 2012

Watson1978 commented Sep 20, 2012

supermarin commented Sep 20, 2012

michael-erasmus commented Sep 20, 2012

clayallsopp commented Sep 20, 2012

michael-erasmus commented Sep 20, 2012

DougPuchalski commented Sep 20, 2012

dmarkow commented Sep 20, 2012

mikesax commented Sep 20, 2012

dmarkow commented Sep 20, 2012

DougPuchalski commented Sep 20, 2012

siuying commented Sep 21, 2012

supermarin commented Sep 21, 2012

siuying commented Sep 26, 2012