Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pretty iam role name, let CloudFormation generate name #161

Merged
merged 6 commits into from
Jan 19, 2019

Conversation

tongueroo
Copy link
Collaborator

@tongueroo tongueroo commented Jan 19, 2019

  • Let CloudFormation generate IAM role names. This addresses really long controller names. Also addresses cross-region deploys.
  • As a part of this fixed long Lambda function names also.
  • Added function description to Lambda functions.

This is a 🐞 bug fix.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

Remove pretty IAM role names. Do not assign pretty role_name because long controller names might hit the 64-char. limit. Also, IAM roles are global, so assigning role names prevents cross region deploys.

Context

#160

Version Changes

@tongueroo tongueroo force-pushed the iam-role-name branch 3 times, most recently from f79a6fa to 72ed092 Compare January 19, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant