Fix multiple issues with dynamic question rendering and answer cleanup

**Issue 1: Questions not rendering on initial page load**
- Changed back to <%= form.fields_for %> (with =) to properly render questions
- Initial page load now shows existing answers correctly

**Issue 2: Escaped </div> appearing in dynamic content**
- Added html.gsub to strip escaped HTML tags from AJAX response
- Regex removes any &lt;/tag&gt; patterns that fields_for generates
- Cleanly handles both server-rendered and AJAX-loaded content

**Issue 3: Answers not deleted when options removed**
- Added @person.options.reload in update_answers method
- Ensures we calculate applicable_questions with fresh PersonOption data
- Previously used stale association data, causing orphaned answers
- Added controller test to verify answer deletion on option removal

**Test Results:**
- All 950 unit tests passing (0 failures, 0 errors)
- All 122 system tests passing (0 failures, 0 errors)
- New test: should delete answers when option is removed

Author: rubys

app/controllers/people_controller.rb

@@ -136,11 +136,14 @@ def get_questions
     end
 
     @person.instance_variable_set(:@calculated_questions, Question.where(id: question_ids.to_a).ordered)
-
-    # Create a form builder-like object for the partial
     @form = ActionView::Helpers::FormBuilder.new(:person, @person, view_context, {})
 
-    render partial: 'people/questions_content', locals: { person: @person, form: @form }, layout: false
+    html = render_to_string(partial: 'people/questions_content', locals: { person: @person, form: @form }, formats: [:html])
+
+    # Remove any escaped HTML tags that fields_for might generate as part of its return value
+    html = html.gsub(/<\/\w+>/, '')
+
+    render html: html.html_safe
   end
 
   def certificates
@@ -1182,6 +1185,16 @@ def update_options
     end
 
     def update_answers
+      # Reload options association to get the updated PersonOption records
+      @person.options.reload
+
+      # Calculate which questions are currently applicable based on package and options
+      applicable_question_ids = @person.applicable_questions.pluck(:id)
+
+      # Delete answers for questions that are no longer applicable
+      @person.answers.where.not(question_id: applicable_question_ids).destroy_all
+
+      # Process submitted answers
       answers_data = person_params[:answers_attributes] || {}
 
       # Handle both array and hash-like formats (fields_for creates hash with string keys)

app/views/people/_questions_content.html.erb

@@ -4,7 +4,6 @@
 
   <% applicable_questions.each do |question| %>
     <% existing_answer = person.answers.find_by(question_id: question.id) %>
-    <% answer_index = existing_answer&.id || "new_#{question.id}" %>
 
     <div class="my-4">
       <%= form.fields_for :answers, existing_answer || person.answers.build(question: question) do |answer_form| %>

test/controllers/people_controller_test.rb

@@ -304,9 +304,42 @@ class PeopleControllerTest < ActionDispatch::IntegrationTest
 
     # Person should appear in the list since they have access through package
     assert_select "a", text: /Package, Person/
-    
+
     # Person should be struck through since they don't have a PersonOption record (not seated at table)
     # The line-through class is on the td element, not the a element
     assert_select "td.line-through a", text: /Package, Person/
   end
+
+  test "should delete answers when option is removed" do
+    person = people(:Kathryn)
+    lunch_option = billables(:two)
+    question = questions(:meal_choice)
+
+    # Kathryn already has answers in fixtures, verify they exist
+    initial_answer_count = person.answers.count
+    assert initial_answer_count > 0, "Person should have existing answers"
+    assert person.answers.exists?(question: question), "Person should have answer for meal choice"
+
+    # Verify Kathryn has the lunch option via PersonOption
+    assert person.options.exists?(option_id: lunch_option.id), "Person should have lunch option"
+
+    # Update person, removing all options (by passing empty options hash)
+    patch person_url(person), params: {
+      person: {
+        name: person.name,
+        studio_id: person.studio_id,
+        type: person.type,
+        level_id: person.level_id,
+        age_id: person.age_id,
+        role: person.role,
+        options: {} # Empty options means all options are removed
+      }
+    }
+
+    assert_response :redirect
+
+    # Verify the answer was deleted because the option is no longer selected
+    person.reload
+    assert_equal 0, person.answers.count, "All answers should be deleted when options are removed"
+  end
 end