Fix: Questions not being saved due to strong parameters issue

Fixed critical bug where questions were not being saved to the database.

Root cause: Rails 8's params.expect() doesn't properly handle nested
attributes with dynamic hash keys (timestamps used for new records).
The questions_attributes hash was being filtered out entirely.

Solution: Changed billable_params from params.expect() to the traditional
params.require().permit() pattern, which correctly handles nested
attributes with arbitrary keys.

Also fixed:
- Added reject_if: proc to accepts_nested_attributes_for to skip questions
  with blank question_text
- Updated process_question_params to set empty choices to nil instead of
  empty array for textarea types

All 949 tests passing.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: rubys

app/controllers/billables_controller.rb

@@ -220,8 +220,9 @@ def set_billable
 
     # Only allow a list of trusted parameters through.
     def billable_params
-      params.expect(billable: [:type, :name, :price, :order, :couples, :table_size, { options: {} }, { packages: {} },
-        { questions_attributes: [:id, :question_text, :question_type, :choices, :order, :_destroy] }])
+      params.require(:billable).permit(:type, :name, :price, :order, :couples, :table_size,
+        options: {}, packages: {},
+        questions_attributes: [:id, :question_text, :question_type, :choices, :order, :_destroy])
     end
 
     def update_includes
@@ -263,7 +264,8 @@ def process_question_params(params)
         if question_attrs[:choices].is_a?(String)
           # Convert newline-separated text to array
           choices_array = question_attrs[:choices].split("\n").map(&:strip).reject(&:blank?)
-          params[:questions_attributes][key][:choices] = choices_array
+          # Set to nil for textarea types (empty array), otherwise use the array
+          params[:questions_attributes][key][:choices] = choices_array.empty? ? nil : choices_array
         end
       end
 

app/models/billable.rb

@@ -22,7 +22,8 @@ class Billable < ApplicationRecord
   has_many :tables, foreign_key: :option_id, dependent: :destroy
   has_many :questions, dependent: :destroy
 
-  accepts_nested_attributes_for :questions, allow_destroy: true
+  accepts_nested_attributes_for :questions, allow_destroy: true,
+    reject_if: proc { |attributes| attributes['question_text'].blank? }
 
   def people
     if type == 'Option'