enhancement: add lint test workflow for charts fix #95 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
|
The workflow was successfully tested with changes in this PR #133, refer to this GitHub Actions run: https://github.com/rucio/helm-charts/actions/runs/4067330595 for the logs of the run. |
|
This is already so much better than what we had. I created a follow-up ticket for further improvements : #134 |
This was referenced Feb 2, 2023
|
Thanks a lot, this is awesome 😄 |
Glad I could help 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #95 by implementing a new helm and lint test workflow in GitHub Actions.
It would probably be a good idea to set this workflow as a merge requirement.