Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow helm best practices #195

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Follow helm best practices #195

merged 3 commits into from
Apr 18, 2024

Conversation

labkode
Copy link
Contributor

@labkode labkode commented Apr 17, 2024 •
edited
Loading

Adhere to best practices when using Helm:

  • Naming templates accordingly depending on the resources they contain.
  • Avoid use of floating tags for images.

@labkode labkode requested a review from rdimaio April 17, 2024 15:47
@labkode labkode marked this pull request as draft April 17, 2024 15:48
@labkode labkode changed the title rucio-daemons: follow helm best practices for template names rucio-daemons: follow helm best practices Apr 17, 2024
@labkode labkode marked this pull request as ready for review April 17, 2024 16:06
@labkode labkode changed the title rucio-daemons: follow helm best practices Follow helm best practices Apr 17, 2024
@labkode
Copy link
Contributor Author

labkode commented Apr 18, 2024

@rdimaio ready to review

@labkode labkode merged commit df09a8f into rucio:master Apr 18, 2024
1 check passed
@labkode labkode deleted the rucio-daemons-naming branch April 18, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdimaio rdimaio rdimaio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkode @rdimaio