Daemons: Remove VO-specifics from replica-recoverer #6396 #6764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cserf
previously approved these changes
May 13, 2024
There was a problem hiding this comment.
Looks good to me but would be good also to have approval from @ChristophAmes
rdimaio
reviewed
May 13, 2024
lib/rucio/daemons/replicarecoverer/suspicious_replica_recoverer.py
Outdated
Show resolved
Hide resolved
rdimaio
reviewed
May 13, 2024
lib/rucio/daemons/replicarecoverer/suspicious_replica_recoverer.py
Outdated
Show resolved
Hide resolved
rdimaio
reviewed
May 13, 2024
lib/rucio/daemons/replicarecoverer/suspicious_replica_recoverer.py
Outdated
Show resolved
Hide resolved
rdimaio
reviewed
May 13, 2024
lib/rucio/daemons/replicarecoverer/suspicious_replica_recoverer.py
Outdated
Show resolved
Hide resolved
rdimaio
reviewed
May 13, 2024
lib/rucio/daemons/replicarecoverer/suspicious_replica_recoverer.py
Outdated
Show resolved
Hide resolved
rdimaio
reviewed
May 13, 2024
lib/rucio/daemons/replicarecoverer/suspicious_replica_recoverer.py
Outdated
Show resolved
Hide resolved
rdimaio
reviewed
May 13, 2024
lib/rucio/daemons/replicarecoverer/suspicious_replica_recoverer.py
Outdated
Show resolved
Hide resolved
rdimaio
reviewed
May 13, 2024
lib/rucio/daemons/replicarecoverer/suspicious_replica_recoverer.py
Outdated
Show resolved
Hide resolved
voetberg
force-pushed
the
feature-6396-replica_recovery_vo_agnostism
branch
from
70073c3
to
62938ab
Compare
expression for an rse to use to filter rse's for recovery; Fix rucio#6396
voetberg
force-pushed
the
feature-6396-replica_recovery_vo_agnostism
branch
from
62938ab
to
be37a81
Compare
rdimaio
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the config to set if the datatype of a replica can be determined via the metadata (metadata[datatype] is not used by all experiments), and uses an rse-expression from the config to redetermine the RSE to use for recovery (removing hardcoded type=SCRATCHDISK). Does not interfere with ATLAS defaults, but does allow more flexibility in the daemons.
Related to PR #6444
cc: @haozturk