Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 53 initial auth workflow #54

Merged
merged 7 commits into from
Aug 25, 2022

Conversation

nimishbongale
Copy link
Member

@nimishbongale nimishbongale commented Jul 22, 2022

Closes #53 #58 #10

Adds the initial workflow for all auths, complete integration with the rucio server will be picked up in a different ticket. With this, the Login page is complete and has all the necessary fields & actions.

@nimishbongale nimishbongale force-pushed the feature-53-initial-auth-workflow branch from 94dbd96 to 1f6c060 Compare July 30, 2022 14:03
src/Login.tsx Outdated Show resolved Hide resolved
@maany
Copy link
Member

maany commented Aug 23, 2022

Hey @nimishbongale ,
I was reviewing this and trying to merge it. However, I ran into errors with the tests, linter and pre-commit hooks.
Could you please rebase this and let me know when I can merge it.
Thanks!

@maany
Copy link
Member

maany commented Aug 24, 2022

We will make the account header optional, so we can refactor this PR to comply with the same.
rucio/rucio#5833

@nimishbongale nimishbongale force-pushed the feature-53-initial-auth-workflow branch from 1a7f89d to 66335bc Compare August 25, 2022 05:26
@maany maany merged commit 5905325 into rucio:master Aug 25, 2022
@nimishbongale nimishbongale deleted the feature-53-initial-auth-workflow branch August 26, 2022 06:15
This was referenced Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial Auth Workflow for UserPass, x509 & OIDC
2 participants