fix: npm install failure on node v16 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there are issues in npm install in node v16 as it is not supported by node-sass v4. So specifying the supported node engine version to be less than node v16.
As node v16+ fails to npm install, putting a strict node version check to make it easier for users to understand that they need node versions below v16.
ameypv-rudder
approved these changes
Sep 23, 2022
shekhar-rudder
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Now the project strictly checks the node version and shows the error if node version is equal or above v16. The core issue was node-sass dependency we have, it's v4 version does not support node versions higher than node v14.
Type of change
Related issues
Checklists
Code review