Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for device mode transformations #160

Merged
merged 62 commits into from
Apr 19, 2023
Merged

feat: added support for device mode transformations #160

merged 62 commits into from
Apr 19, 2023

Conversation

desusai7
Copy link
Contributor

@desusai7 desusai7 commented Jun 6, 2022 •
edited by SumanthPuram
Loading

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Version updated in README
  • Version updated in RSConstants.m(v1)/RSConstant.swift(v2)
  • Version updated in Rudder.xcodeproj
  • Version updated in Rudder.podspec
  • CHANGELOG Updated
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation
  • Passed pod lib lint --no-clean --allow-warnings

This change is Reviewable

@pallabmaiti pallabmaiti marked this pull request as draft June 7, 2022 06:10
@desusai7
Flushing Events to Transformation Server Periodically
c5ff82d
@desusai7
Using fromHistory flag for replaying messages to better maintain the …
a54af70 
…sequence
@desusai7
Updated Parsing logic as per the response of the sourceConfig endpoint
4ccd59e
@desusai7
Imposed Max Batch Size for the /transform endpoint as well and made t…
03af1af 
…he periodic calls synchronous
@desusai7
Updated the Device Mode Transformations logic as per the design changes
02ec6f9
@desusai7
Fixed the issue of Multiple threads in parallel for Transformation Pr…
761901e 
…ocessor
@desusai7
Fixed issues while converting back json to RSMessage
52c9633
@desusai7
Stopped Sending DestinationIds in the payload to transformation service
4c0ebee
@desusai7
Modified Parsing logic of response from Transformation Service
535164b
@desusai7
Added Unit Test Cases for Device Mode Transformations
0faf500
@desusai7
Minor changes
b7bdba9
@desusai7
Checking Status at Event Level in case of Transformed Events for Devi…
96d1480 
…ce Mode
@desusai7
Improved the performance by optimizing the db operations
1e7922a
@desusai7
Refactored the EventRepository and DMT Logic
323835f
@desusai7 desusai7 marked this pull request as ready for review August 10, 2022 05:36
pallabmaiti
pallabmaiti reviewed Aug 10, 2022
View reviewed changes
Copy link
Contributor

@pallabmaiti pallabmaiti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .DS_Store files. Add this to .gitignore.

pallabmaiti
pallabmaiti reviewed Aug 10, 2022
View reviewed changes
Sources/Classes/RSApplicationLifeCycleManager.m Show resolved Hide resolved
Sources/Classes/RSApplicationLifeCycleManager.m Show resolved Hide resolved
Sources/Classes/Public/RSNetworkManager.h Outdated Show resolved Hide resolved
Sources/Classes/RSDBPersistentManager.m Outdated Show resolved Hide resolved
Sources/Classes/RSDeviceModeManager.m Outdated Show resolved Hide resolved
Sources/Classes/RSDeviceModeManager.m Show resolved Hide resolved
Sources/Classes/RSNetworkManager.m Outdated Show resolved Hide resolved
@desusai7 desusai7 changed the title [Feature] Device Mode Transformations feat: added support for device mode transformations Mar 21, 2023
@desusai7 desusai7 self-assigned this Mar 21, 2023
@pallabmaiti pallabmaiti force-pushed the feature/deviceModeTransformations branch from 60f9fb4 to 6bba6d2 Compare March 21, 2023 16:11
pallabmaiti
pallabmaiti reviewed Mar 21, 2023
View reviewed changes
Sources/Classes/RSContext.m Outdated Show resolved Hide resolved
Sources/Classes/RSNetworkManager.m Outdated Show resolved Hide resolved
Sources/Classes/RSDeviceModeManager.m Outdated Show resolved Hide resolved
Sources/Classes/Headers/Public/RSDBMessage.h Outdated Show resolved Hide resolved
Sources/Classes/Headers/Public/RSNetworkEnums.h Outdated Show resolved Hide resolved
Sources/Classes/Headers/Public/RSUtils.h Outdated Show resolved Hide resolved
Sources/Classes/Headers/Public/RSDBPersistentManager.h Outdated Show resolved Hide resolved
Podfile Outdated Show resolved Hide resolved
Tests/ServerConfigManagerTests.swift Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 55 Code Smells

23.2% 23.2% Coverage
0.8% 0.8% Duplication

@1abhishekpandey 1abhishekpandey merged commit 9f145eb into develop Apr 19, 2023
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Apr 19, 2023
Merged
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Jun 8, 2023
Closed
@pallabmaiti pallabmaiti deleted the feature/deviceModeTransformations branch August 23, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pallabmaiti pallabmaiti pallabmaiti approved these changes

@itsdebs itsdebs Awaiting requested review from itsdebs

@1abhishekpandey 1abhishekpandey Awaiting requested review from 1abhishekpandey

Assignees

@desusai7 desusai7

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desusai7 @pallabmaiti @1abhishekpandey