-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(jobsdb): unify get processed and unprocessed queries #3742
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3742 +/- ##
==========================================
- Coverage 68.80% 68.54% -0.27%
==========================================
Files 344 344
Lines 51936 51259 -677
==========================================
- Hits 35736 35136 -600
+ Misses 13896 13854 -42
+ Partials 2304 2269 -35
☔ View full report in Codecov by Sentry. |
9a6aee5
to
1243a54
Compare
2d84675
to
6c4f7c1
Compare
48f4306
to
57ae64d
Compare
57ae64d
to
db33a50
Compare
Description
By unifying
getUnprocessed
andgetProcessed
under a singlegetJobs
method which is able to handle both processed and unprocessed job states with a single database query, we can execute less queries, which translates to lower overall query times and finally less jobsdb locks:GetToProcess
query instead of 3 (GetToRetry
,GetWaiting
,GetUnprocessed
)GetToProcess
query instead of 2 (GetToRetry
,GetUnprocessed
)GetToProcess
query instead of 2 (GetToRetry
,GetUnprocessed
)Other changes:
jobsdb.GetQueryParamsT
tojobsdb.GetQueryParams
jobsdb.HandleT
tojobsdb.Handle
dbRequest
sMonitoring dashboard adaptations
After this change has been rolled out, we need to unify the following JobsDB panels in Grafana under a single Get Jobs Stats panel:
Linear Ticket
Link
Security