Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove archival for jobsdb journal tables #3758

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

Sidddddarth
Copy link
Member

Description

Removes archival for journal table entries. The cleanup for said entries is moved to jobsdb's cleanup routine.

Linear Ticket

remove jobsdb journal archival

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% 🎉

Comparison is base (c65ded3) 68.67% compared to head (ff405b5) 68.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3758      +/-   ##
==========================================
+ Coverage   68.67%   68.74%   +0.07%     
==========================================
  Files         347      345       -2     
  Lines       51989    51917      -72     
==========================================
- Hits        35702    35692      -10     
+ Misses      13988    13936      -52     
+ Partials     2299     2289      -10     
Files Changed Coverage Δ
runner/runner.go 69.54% <ø> (-0.25%) ⬇️
jobsdb/admin.go 87.77% <100.00%> (+4.14%) ⬆️
jobsdb/jobsdb.go 72.72% <100.00%> (-0.12%) ⬇️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants