Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deltalake error message length #3766

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Aug 19, 2023

Description

  • While creating an external table, we are getting an error since there is already some data present specifying some other schema, and in the error messages, it's dumping the entire other schema which is coming to be very huge. It's reaching around 20MB.
  • For delta lake, trim error if it exceeds 64KB

Linear Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr force-pushed the fix.databricks-max-error-length branch from 6dd63b9 to e521806 Compare August 19, 2023 09:23
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.40% ⚠️

Comparison is base (e6892a2) 68.64% compared to head (4fa6b1c) 68.24%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.12.x    #3766      +/-   ##
==================================================
- Coverage           68.64%   68.24%   -0.40%     
==================================================
  Files                 337      334       -3     
  Lines               52467    51526     -941     
==================================================
- Hits                36014    35162     -852     
+ Misses              14146    14080      -66     
+ Partials             2307     2284      -23     
Files Changed Coverage Δ
warehouse/integrations/deltalake/deltalake.go 74.79% <88.88%> (+0.50%) ⬆️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

warehouse/integrations/deltalake/deltalake.go Outdated Show resolved Hide resolved
@achettyiitr achettyiitr merged commit fa09173 into release/1.12.x Aug 22, 2023
31 checks passed
@achettyiitr achettyiitr deleted the fix.databricks-max-error-length branch August 22, 2023 06:16
@achettyiitr achettyiitr changed the title chore: deltalake error message length fix: deltalake error message length Aug 22, 2023
@achettyiitr achettyiitr changed the title fix: deltalake error message length chore: deltalake error message length Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants