Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed quote Identifier on sourceDestId #2763

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

chaitanyapraveen
Copy link
Contributor

@chaitanyapraveen chaitanyapraveen commented Dec 1, 2022

Description

Quote Identifier on sourceOrDestId is constructing a wrong SQL query resulting incorrect value for pendingstagingcount

Notion Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 46.91% // Head: 46.79% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (675e9f0) compared to base (73fc7ea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/1.4.x    #2763      +/-   ##
=================================================
- Coverage          46.91%   46.79%   -0.13%     
=================================================
  Files                300      300              
  Lines              49165    49164       -1     
=================================================
- Hits               23066    23005      -61     
- Misses             24632    24696      +64     
+ Partials            1467     1463       -4     
Impacted Files Coverage Δ
warehouse/warehouse.go 9.96% <ø> (-0.06%) ⬇️
processor/stash/stash.go 44.56% <0.00%> (-22.10%) ⬇️
testhelper/freeport.go 66.66% <0.00%> (-13.34%) ⬇️
jobsdb/migration.go 76.94% <0.00%> (-1.30%) ⬇️
jobsdb/backup.go 75.45% <0.00%> (-0.37%) ⬇️
jobsdb/jobsdb.go 73.02% <0.00%> (-0.13%) ⬇️
router/router.go 73.86% <0.00%> (+0.18%) ⬆️
services/db/recovery.go 55.95% <0.00%> (+1.19%) ⬆️
config/backend-config/namespace_config.go 70.00% <0.00%> (+3.00%) ⬆️
...rvices/streammanager/kafka/client/testutil/util.go 70.87% <0.00%> (+3.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@achettyiitr achettyiitr merged commit 2cc87f4 into release/1.4.x Dec 2, 2022
@cisse21 cisse21 deleted the fix.removeQuoteIdentifier branch December 13, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants