Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade postgres image #2764

Merged
merged 1 commit into from
Dec 2, 2022
Merged

chore: upgrade postgres image #2764

merged 1 commit into from
Dec 2, 2022

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Dec 1, 2022

Description

Upgrading Postgres to 15 in the default docker-compose file and the relevant tests

Notion Ticket

Notion Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 46.95% // Head: 46.95% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (58ed76f) compared to base (7495019).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2764   +/-   ##
=======================================
  Coverage   46.95%   46.95%           
=======================================
  Files         300      300           
  Lines       49160    49160           
=======================================
+ Hits        23081    23085    +4     
+ Misses      24614    24612    -2     
+ Partials     1465     1463    -2     
Impacted Files Coverage Δ
testhelper/destination/postgres.go 67.56% <100.00%> (ø)
router/router.go 73.68% <0.00%> (-0.19%) ⬇️
warehouse/schema.go 51.42% <0.00%> (+1.14%) ⬆️
config/backend-config/namespace_config.go 70.00% <0.00%> (+3.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cisse21 cisse21 merged commit 9e80fa0 into master Dec 2, 2022
@cisse21 cisse21 deleted the chore.upgradePostgres branch December 2, 2022 09:38
@@ -66,7 +66,7 @@ func run(m *testing.M) int {

database := "jobsdb"
// pulls an image, creates a container based on it and runs it
resourcePostgres, err := pool.Run("postgres", "11-alpine", []string{
resourcePostgres, err := pool.Run("postgres", "15-alpine", []string{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are still using postgres-11 in various environments, shouldn't we leave it as is until we upgrade them first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants