Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessary router pending event counts #2849

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Jan 5, 2023

Description

Fixes unnecessary extra statistics captured at router level, where pending event Gauges were initialized for all destinations for all workspaces served by the server instance.

Notion Ticket

fix router pending event alerts

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth changed the title fix unnecessary router pending event counts fix: unnecessary router pending event counts Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 47.62% // Head: 47.65% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (b8cf5c1) compared to base (0459aff).
Patch coverage: 67.59% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2849      +/-   ##
==========================================
+ Coverage   47.62%   47.65%   +0.03%     
==========================================
  Files         311      311              
  Lines       49687    49708      +21     
==========================================
+ Hits        23663    23689      +26     
+ Misses      24580    24578       -2     
+ Partials     1444     1441       -3     
Impacted Files Coverage Δ
router/batchrouter/batchrouter.go 37.53% <6.25%> (-0.09%) ⬇️
services/multitenant/tenantstats.go 89.24% <12.50%> (-1.63%) ⬇️
processor/processor.go 86.34% <76.78%> (+0.01%) ⬆️
router/router.go 76.69% <100.00%> (+0.23%) ⬆️
jobsdb/migration.go 76.94% <0.00%> (+3.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sidddddarth Sidddddarth force-pushed the chore.pendingEventsCount branch 2 times, most recently from f825e66 to bef2959 Compare January 6, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants