Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: job ordering inconsistencies with router destination isolation #3030

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Feb 22, 2023

Description

Missing parameter filters can cause no-jobs cache to not get invalidated properly, ultimately leading to out-of-order jobs.

Additionally, now using a proper order key during throttling so that same userIDs of different destinationIDs are not being throttled together.

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/1.6.x@0742fd7). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 9a7c774 differs from pull request most recent head df20c69. Consider uploading reports for the commit df20c69 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             release/1.6.x    #3030   +/-   ##
================================================
  Coverage                 ?   52.85%           
================================================
  Files                    ?      338           
  Lines                    ?    52136           
  Branches                 ?        0           
================================================
  Hits                     ?    27555           
  Misses                   ?    22972           
  Partials                 ?     1609           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum merged commit a77c382 into release/1.6.x Feb 23, 2023
@atzoum atzoum deleted the fix.jobOrderRouterIsolation branch February 23, 2023 07:50
This was referenced Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants