Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: initiate db handle warehouse slave #3270

Merged
merged 3 commits into from
May 4, 2023

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented May 3, 2023

Description

  • Initiate db handle in warehouse slave
  • Fix deadlock issue faced on multi-tenant production

Notion Ticket

Notion Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@cisse21 cisse21 force-pushed the chore.initiateSlaveDBHandle branch from 4753515 to b4274d6 Compare May 3, 2023 19:49
@cisse21 cisse21 requested review from lvrach and achettyiitr May 3, 2023 19:49
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (e0280e4) 51.91% compared to head (fd85925) 51.93%.

❗ Current head fd85925 differs from pull request most recent head 5215560. Consider uploading reports for the commit 5215560 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3270      +/-   ##
==========================================
+ Coverage   51.91%   51.93%   +0.01%     
==========================================
  Files         322      322              
  Lines       53400    53398       -2     
==========================================
+ Hits        27721    27730       +9     
+ Misses      24024    24014      -10     
+ Partials     1655     1654       -1     
Impacted Files Coverage Δ
...ebugger/destination/eventDeliveryStatusUploader.go 86.92% <ø> (-0.20%) ⬇️
warehouse/warehouse.go 12.79% <0.00%> (-0.16%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants