Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save webhook (/source transformation) failures to proc errors #3522

Merged
merged 14 commits into from
Jul 6, 2023

Conversation

chandumlg
Copy link
Member

@chandumlg chandumlg commented Jun 20, 2023

Description

Save webhook (/source transformation) failures to proc errors.

To make this happen, I had to create two instances of proc error jobsdbs (one in read mode and one in write mode). Router and Batch router take write error jobsdb, gateway needs write error jobsdb & processor needs both read and write jobsdbs.

Multitenant scenario: This change should not create any problems in multi-tenant deployment (since proc error jobsdb behavior will be similar to gw jobsdb)

Notion Ticket

https://www.notion.so/rudderstacks/d5d15ce4be354e3caae11d4ea9f41477?v=2ad23dce1aeb431a82f783e6607d3cb0&p=334353dc6e204af188569cb5646f13d4&pm=c

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@chandumlg chandumlg force-pushed the feat.store-webhook-failures-to-dlq branch from 771d743 to 05861fb Compare June 26, 2023 22:12
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 61.26% and project coverage change: -0.34 ⚠️

Comparison is base (a8abd1d) 68.31% compared to head (5a8000d) 67.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3522      +/-   ##
==========================================
- Coverage   68.31%   67.97%   -0.34%     
==========================================
  Files         318      318              
  Lines       50284    50376      +92     
==========================================
- Hits        34353    34245     -108     
- Misses      13699    13895     +196     
- Partials     2232     2236       +4     
Impacted Files Coverage Δ
app/apphandlers/gatewayAppHandler.go 12.62% <0.00%> (-1.67%) ⬇️
app/apphandlers/processorAppHandler.go 9.32% <0.00%> (-0.46%) ⬇️
gateway/webhook/setup.go 100.00% <ø> (ø)
gateway/webhook/webhook.go 56.11% <63.15%> (+0.37%) ⬆️
app/apphandlers/embeddedAppHandler.go 76.13% <85.00%> (+0.04%) ⬆️
gateway/gateway.go 79.82% <85.18%> (+0.13%) ⬆️
gateway/mocks/mockwebhook.go 100.00% <100.00%> (ø)
processor/manager.go 94.73% <100.00%> (+0.09%) ⬆️
processor/processor.go 87.61% <100.00%> (+<0.01%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chandumlg chandumlg changed the title feat: split errorDBRW into errorDBR and errorDBW feat: save webhook (/source transformation) failures to proc errors Jun 28, 2023
@chandumlg chandumlg marked this pull request as ready for review June 28, 2023 05:32
app/apphandlers/embeddedAppHandler.go Outdated Show resolved Hide resolved
app/apphandlers/processorAppHandler.go Show resolved Hide resolved
app/apphandlers/gatewayAppHandler.go Outdated Show resolved Hide resolved
app/apphandlers/gatewayAppHandler.go Outdated Show resolved Hide resolved
gateway/gateway.go Show resolved Hide resolved
gateway/gateway.go Outdated Show resolved Hide resolved
@chandumlg chandumlg merged commit 45a1802 into master Jul 6, 2023
@chandumlg chandumlg deleted the feat.store-webhook-failures-to-dlq branch July 6, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants