-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: save webhook (/source transformation) failures to proc errors #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandumlg
force-pushed
the
feat.store-webhook-failures-to-dlq
branch
from
June 26, 2023 22:12
771d743
to
05861fb
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3522 +/- ##
==========================================
- Coverage 68.31% 67.97% -0.34%
==========================================
Files 318 318
Lines 50284 50376 +92
==========================================
- Hits 34353 34245 -108
- Misses 13699 13895 +196
- Partials 2232 2236 +4
☔ View full report in Codecov by Sentry. |
chandumlg
changed the title
feat: split errorDBRW into errorDBR and errorDBW
feat: save webhook (/source transformation) failures to proc errors
Jun 28, 2023
atzoum
reviewed
Jun 30, 2023
atzoum
reviewed
Jul 3, 2023
cisse21
reviewed
Jul 4, 2023
atzoum
approved these changes
Jul 6, 2023
cisse21
approved these changes
Jul 6, 2023
Merged
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Save webhook (/source transformation) failures to proc errors.
To make this happen, I had to create two instances of proc error jobsdbs (one in read mode and one in write mode). Router and Batch router take write error jobsdb, gateway needs write error jobsdb & processor needs both read and write jobsdbs.
Multitenant scenario: This change should not create any problems in multi-tenant deployment (since proc error jobsdb behavior will be similar to gw jobsdb)
Notion Ticket
https://www.notion.so/rudderstacks/d5d15ce4be354e3caae11d4ea9f41477?v=2ad23dce1aeb431a82f783e6607d3cb0&p=334353dc6e204af188569cb5646f13d4&pm=c
Security