Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocoapods themes path #57

Merged
merged 4 commits into from
Apr 20, 2020

Conversation

rivera-ernesto
Copy link
Contributor

Fix theme loading for Cocoapods installations that have yet another path format.

Also public init(_ name: String) maybe better changed to an optional init?(...) as it is not guaranteed that any name will result in a Theme.

Notepad/Theme.swift Outdated Show resolved Hide resolved
Co-Authored-By: Christian Tietze <me@christiantietze.de>
@ruddfawcett ruddfawcett mentioned this pull request Apr 6, 2020
@ruddfawcett
Copy link
Owner

Sorry this took so long to pull in, @rivera-ernesto. Thank you!

@ruddfawcett ruddfawcett merged commit 5b46880 into ruddfawcett:master Apr 20, 2020
@rivera-ernesto rivera-ernesto deleted the cocoapods_themes_path branch April 20, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants