Updated string constraint extension #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't necessarily commit this yet - I'm going through the naming constraints and adding more as I see them |
…re string does not contain or does not start with). Added more unit tests.
|
Good to go - this spans nearly all the naming constraints listed in the docs. |
Perfect, might be worth standardising the resources that are supported "centrally" and defining these rules (automatically?) so they can be re-used everywhere, but a later thing - will raise an issue for it so I don't forget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made all constraints optional so not all have to be specified where inapplicable, added check for start/end characters. Added/updated unit tests.