improve CI and build scripts #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... across GHC 9.6 compared to earlier versions.
The following test was failing on GHC 9.6:
```haskell
-- showTypesInTypeOf (u :: Either String Bool -> Maybe Int -> Int -> Bool)
map show . typesIn . typeOf (undefined :: Either String Bool -> Maybe Int -> Int -> Bool)
== [ "Bool"
, "Char"
, "Int"
, "Maybe Int"
, "[Char]"
, "Either [Char] Bool"
, "Int -> Bool"
, "Maybe Int -> Int -> Bool"
, "Either [Char] Bool -> Maybe Int -> Int -> Bool"
]
```
Here's what happens on GHC 9.0:
```haskell
> map show . typesIn . typeOf (undefined :: String -> Maybe Int)
[ "Char"
, "Int"
, "Maybe Int"
, "[Char]"
, "[Char] -> Maybe Int"
]
```
Here's what happens on GHC 9.6:
```haskell
> map show . typesIn . typeOf (undefined :: String -> Maybe Int)
[ "Char"
, "Int"
, "[Char]"
, "Maybe Int"
, "[Char] -> Maybe Int"
]
```
The types `[Char]` and `Maybe Int` are reported in a different order!
This relates to the function `compareTy` from `Data.Express.Utils.Typeable`
which is a (tentative) consistent replacement to `compare :: TypeRep -> ...`
over different GHC versions (this was important to some of my research).
It became inconsistent with the new GHC.
```haskell
-- with
> let string = typeOf (undefined :: String)
> let mint = typeOf (undefined :: Maybe Int)
-- on GHC <= 9.4
> compareTy string mint
GT
-- on GHC == 9.6
> compareTy string mint
LT
```
The issue is related to showing the list `TyCon` (`[]`)
which changed to being stringified as `[]` to `List`.
On GHCs 9.0, 9.2, 9.4:
```haskell
> splitTyConApp $ typeOf (undefined :: String)
([],[Char])
```
On GHC 9.6:
```haskell
> splitTyConApp $ typeOf (undefined :: String)
(List,[Char])
```
The function `compareTy` is now amended considering this caveat
and now consistent for all GHCs <= 9.6 and hopefully most future versions.
This is fixed in this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.