Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Papa's Burgeria: Hover state change does not update button #11907

Closed
n0samu opened this issue Jul 5, 2023 · 2 comments · Fixed by #14856
Closed

Papa's Burgeria: Hover state change does not update button #11907

n0samu opened this issue Jul 5, 2023 · 2 comments · Fixed by #14856
Labels
A-avm2 Area: AVM2 (ActionScript 3) A-rendering Area: Rendering & Graphics bug Something isn't working

Comments

@n0samu
Copy link
Member

n0samu commented Jul 5, 2023

Describe the bug

In Papa's Burgeria, hovering over the Play button on the main menu does not always highlight the button as expected, and moving the mouse away doesn't immediately remove the highlight. Also, moving the mouse away does not immediately play/restart the left-to-right highlight animation on the button like it should. Here is an isolated SWF with just the menu buttons to test: BurgeriaMenuButtons.zip
ruffle_burgeriabuttons

Expected behavior

Here is how the button behaves in Flash Player:
flashplayer_burgeriabuttons

  • Hovering over the button immediately highlights it
  • Moving the cursor away immediately removes the highlight, then plays the button's left-to-right highlight/attract animation

Affected platform

Desktop app

Operating system

Windows 10

Browser

No response

Additional information

I've bisected the issues with the highlight not being added/removed to commit fe74219 from #11638. But even before that, the left-to-right highlight/attract animation didn't immediately play when moving the mouse away from the button, so that might be a separate issue.

@n0samu n0samu added bug Something isn't working A-rendering Area: Rendering & Graphics A-avm2 Area: AVM2 (ActionScript 3) labels Jul 5, 2023
@n0samu
Copy link
Member Author

n0samu commented Jul 5, 2023

Here is an AVM1 SWF with the exact same button: BurgeriaButtonAS2.zip

Notice that this button behaves perfectly fine. This must be an issue only with Ruffle's AVM2 button, even though ActionScript is not involved.

@n0samu
Copy link
Member Author

n0samu commented Jan 20, 2024

Koutack has a similar problem - hovering over the buttons on the "level cleared" screen does not highlight them.

Ruffle:
image

Flash:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) A-rendering Area: Rendering & Graphics bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant