build(deps-dev): bump chai from 4.4.1 to 5.1.0 in /web #15877

dependabot · 2024-04-04T18:43:03Z

Bumps chai from 4.4.1 to 5.1.0.

Release notes

v5.1.0

What's Changed

Remove useless guards and add parentheses to constuctors by @koddsson in chaijs/chai#1593

Cleanup jsdoc comments by @koddsson in chaijs/chai#1596

Convert comments in "legal comments" format to jsdoc or normal comments by @koddsson in chaijs/chai#1598

Implement iterable assertion by @koddsson in chaijs/chai#1592

Assert interface fix by @developer-bandi in chaijs/chai#1601

Set support in same members by @koddsson in chaijs/chai#1583

Fix publish script by @koddsson in chaijs/chai#1602

New Contributors

@developer-bandi made their first contribution in chaijs/chai#1601

Full Changelog: chaijs/chai@v5.0.3...v5.1.0

v5.0.3

Fix bad v5.0.2 publish.

Full Changelog: chaijs/chai@v5.0.2...v5.0.3

v5.0.2

What's Changed

build(deps): bump nanoid and mocha by @dependabot in chaijs/chai#1558

remove bump-cli by @koddsson in chaijs/chai#1559

Update developer dependencies by @koddsson in chaijs/chai#1560

fix: removes ?? for node compat (5.x) by @43081j in chaijs/chai#1576

Update loupe to latest version by @koddsson in chaijs/chai#1579

Re-enable some webkit tests by @koddsson in chaijs/chai#1580

Remove a bunch of if statements in test/should.js by @koddsson in chaijs/chai#1581

Remove a bunch of unused files by @koddsson in chaijs/chai#1582

Fix 1564 by @koddsson in chaijs/chai#1566

Full Changelog: chaijs/chai@v5.0.1...v5.0.2

v5.0.0

BREAKING CHANGES

Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have import {...} from 'chai' or import('chai'). require('chai') will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls.

Dropped support for Internet Explorer.

Dropped support for NodeJS < 18.

Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome 100, Edge 100. Support for browsers prior to these versions is "best effort" (bug reports on older browsers will be assessed individually and may be marked as wontfix).

What's Changed

feat: use chaijs/loupe for inspection by @pcorpet in chaijs/chai#1401

docs: fix URL in README by @Izzur in chaijs/chai#1413

Remove get-func-name dependency by @koddsson in chaijs/chai#1416

Convert Makefile script to npm scripts by @koddsson in chaijs/chai#1424

Clean up README badges by @koddsson in chaijs/chai#1422

fix: package.json - deprecation warning on exports field by @stevenjoezhang in chaijs/chai#1400

fix: deep-eql bump package to support symbols by @snewcomer in chaijs/chai#1458

... (truncated)

Commits

2cf92f5 Fix publish script (#1602)
1ba37b5 Set support in same members (#1583)
f224339 Assert interface fix (#1601)
d504573 Implement iterable assertion (#1592)
640d932 Convert comments in "legal comments" format to jsdoc (#1598)
e7f768e Cleanup jsdoc comments (#1596)
3290eb4 Remove useless guards and add parentheses to constuctors (#1593)
44b81df 5.0.3
1a4dca1 5.0.2
57fef84 Fix 1564 (#1566)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

danielhjacobs · 2024-04-04T19:51:26Z

Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have import {...} from 'chai' or import('chai'). require('chai') will cause failures in nodejs.

This PR will not be mergeable until all our tests are changed to use ESM.

torokati44 · 2024-04-04T20:34:31Z

Huh, interesting that chai-html was able to updated.

danielhjacobs · 2024-04-04T20:39:15Z

Huh, interesting that chai-html was able to updated.

Was it? When was that? It's still on version 2.1.0, when the latest version is 3.0.0 according to https://www.npmjs.com/package/chai-html?activeTab=versions:

ruffle/web/package.json

Line 19 in 13f7456

"chai-html": "^2.1.0",

danielhjacobs · 2024-04-04T20:41:36Z

These 42 files need updates: https://github.com/search?q=repo%3Aruffle-rs%2Fruffle+chai+path%3A%2F%5Eweb%5C%2Fpackages%5C%2Fselfhosted%5C%2Ftest%5C%2F%2F&type=code

That's every JS file in https://github.com/ruffle-rs/ruffle/tree/master/web/packages/selfhosted/test

torokati44 · 2024-04-04T20:53:05Z

Was it? When was that?

Okay it wasn't then. I just saw it listed in #15365, but not here, so I assumed it must have gotten done sometime... Sorry.

torokati44 · 2024-04-04T21:03:42Z

Something like this? ☝️
EDIT: Not quite... 😅

danielhjacobs · 2024-04-04T21:13:28Z

Add to the self-hosted package.json this:

ruffle/web/packages/extension/package.json

Line 7 in 4c8c3b1

"type": "module",

Not as sure about this, but not sure you can mix and match import with require

danielhjacobs · 2024-04-04T22:22:07Z

I think the next issue is the webpack config needs to be an export similar to this:

https://github.com/ruffle-rs/ruffle/blob/master/web/packages/extension/webpack.config.js#L71

torokati44 · 2024-04-04T22:23:49Z

Yes, just what I was looking for, thank you! 🙏

danielhjacobs · 2024-04-04T22:32:32Z

See path: path.resolve(__dirname, "dist"),

Compare to https://github.com/ruffle-rs/ruffle/blob/master/web/packages/extension/webpack.config.js#L90

For reference https://stackoverflow.com/questions/8817423/why-is-dirname-not-defined-in-node-repl

danielhjacobs · 2024-04-04T22:49:45Z

Damn, current error seems to be because the tests are full of __dirname references.

Edit: https://github.com/search?q=repo%3Aruffle-rs%2Fruffle+__dirname+path%3A%2F%5Eweb%5C%2Fpackages%5C%2Fselfhosted%5C%2F%2F+path%3A%2F%5Eweb%5C%2Fpackages%5C%2Fselfhosted%5C%2Ftest%5C%2Fpolyfill%5C%2F%2F&type=code

torokati44 · 2024-04-04T22:51:07Z

But how come it passes on Windows? 😱

danielhjacobs · 2024-04-04T22:51:41Z

Windows hasn't run tests for a while.

torokati44 · 2024-04-04T22:52:00Z

Yeah, right... oh...

danielhjacobs · 2024-04-04T22:54:19Z

Proof positive for progress though, 3 tests passed (the JS API tests don't use __dirname)

torokati44 · 2024-04-04T22:57:26Z

Oh, will this work for us?

Starting with Node.js 20.11 / 21.2, you can use import.meta.dirname

const __dirname = import.meta.dirname;

https://stackoverflow.com/a/50052194/635587

danielhjacobs · 2024-04-04T23:01:50Z

Worth a shot. We no longer test Node 18 on CI, but we don't call it unsupported. This would make it unsupported, but just for tests I guess, so I feel like that's fine personally if no one disagrees.

danielhjacobs · 2024-04-04T23:05:12Z

Looks like you need to run npm run format

torokati44 · 2024-04-04T23:16:09Z

It's gween!

danielhjacobs

Approving because all checks are green and I see nothing obviously wrong. I don't consider myself qualified to fully review changing all our tests to ESM (which as a note, is one thing done by this PR), so hoping for another review.

Dinnerbone

Looks totally fine to me. Thank you both!

Bumps [chai](https://github.com/chaijs/chai) from 4.4.1 to 5.1.0. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/main/History.md) - [Commits](chaijs/chai@v4.4.1...v5.1.0) --- updated-dependencies: - dependency-name: chai dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 4, 2024

dependabot bot force-pushed the dependabot/npm_and_yarn/web/chai-5.1.0 branch 2 times, most recently from b6ec708 to 75b2e04 Compare April 4, 2024 19:49

dependabot bot force-pushed the dependabot/npm_and_yarn/web/chai-5.1.0 branch from 75b2e04 to fc0c02c Compare April 4, 2024 20:07

torokati44 force-pushed the dependabot/npm_and_yarn/web/chai-5.1.0 branch 3 times, most recently from ad598fd to 0270916 Compare April 4, 2024 22:12

torokati44 force-pushed the dependabot/npm_and_yarn/web/chai-5.1.0 branch from 0270916 to 3c75145 Compare April 4, 2024 22:23

torokati44 force-pushed the dependabot/npm_and_yarn/web/chai-5.1.0 branch from 3c75145 to cf93537 Compare April 4, 2024 22:34

torokati44 force-pushed the dependabot/npm_and_yarn/web/chai-5.1.0 branch 2 times, most recently from 57671c5 to f470968 Compare April 4, 2024 23:06

torokati44 force-pushed the dependabot/npm_and_yarn/web/chai-5.1.0 branch 2 times, most recently from 3dca3e7 to 23b570e Compare April 8, 2024 15:15

danielhjacobs added the waiting-on-review Waiting on review from a Ruffle team member label Apr 8, 2024

danielhjacobs approved these changes Apr 8, 2024

View reviewed changes

torokati44 force-pushed the dependabot/npm_and_yarn/web/chai-5.1.0 branch from 23b570e to 3f15d1e Compare April 8, 2024 20:29

Dinnerbone approved these changes Apr 8, 2024

View reviewed changes

dependabot bot and others added 2 commits April 8, 2024 23:19

web: Port the selfhosted package to modules

0d08c53

torokati44 force-pushed the dependabot/npm_and_yarn/web/chai-5.1.0 branch from 3f15d1e to 0d08c53 Compare April 8, 2024 21:19

torokati44 enabled auto-merge (rebase) April 8, 2024 21:20

torokati44 merged commit bffa2e8 into master Apr 8, 2024
15 checks passed

dependabot bot deleted the dependabot/npm_and_yarn/web/chai-5.1.0 branch April 8, 2024 21:26

Lord-McSweeney removed the waiting-on-review Waiting on review from a Ruffle team member label Apr 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(deps-dev): bump chai from 4.4.1 to 5.1.0 in /web #15877

build(deps-dev): bump chai from 4.4.1 to 5.1.0 in /web #15877

dependabot bot commented on behalf of github Apr 4, 2024 •

edited

danielhjacobs commented Apr 4, 2024 •

edited

torokati44 commented Apr 4, 2024 •

edited

danielhjacobs commented Apr 4, 2024 •

edited

danielhjacobs commented Apr 4, 2024 •

edited

torokati44 commented Apr 4, 2024

torokati44 commented Apr 4, 2024 •

edited

danielhjacobs commented Apr 4, 2024

danielhjacobs commented Apr 4, 2024 •

edited

torokati44 commented Apr 4, 2024

danielhjacobs commented Apr 4, 2024 •

edited

danielhjacobs commented Apr 4, 2024 •

edited

torokati44 commented Apr 4, 2024

danielhjacobs commented Apr 4, 2024

torokati44 commented Apr 4, 2024

danielhjacobs commented Apr 4, 2024

torokati44 commented Apr 4, 2024

danielhjacobs commented Apr 4, 2024

danielhjacobs commented Apr 4, 2024

torokati44 commented Apr 4, 2024

danielhjacobs left a comment

Dinnerbone left a comment

build(deps-dev): bump chai from 4.4.1 to 5.1.0 in /web #15877

build(deps-dev): bump chai from 4.4.1 to 5.1.0 in /web #15877

Conversation

dependabot bot commented on behalf of github Apr 4, 2024 • edited

v5.1.0

What's Changed

New Contributors

v5.0.3

v5.0.2

What's Changed

v5.0.0

BREAKING CHANGES

What's Changed

danielhjacobs commented Apr 4, 2024 • edited

torokati44 commented Apr 4, 2024 • edited

danielhjacobs commented Apr 4, 2024 • edited

danielhjacobs commented Apr 4, 2024 • edited

torokati44 commented Apr 4, 2024

torokati44 commented Apr 4, 2024 • edited

danielhjacobs commented Apr 4, 2024

danielhjacobs commented Apr 4, 2024 • edited

torokati44 commented Apr 4, 2024

danielhjacobs commented Apr 4, 2024 • edited

danielhjacobs commented Apr 4, 2024 • edited

torokati44 commented Apr 4, 2024

danielhjacobs commented Apr 4, 2024

torokati44 commented Apr 4, 2024

danielhjacobs commented Apr 4, 2024

torokati44 commented Apr 4, 2024

danielhjacobs commented Apr 4, 2024

danielhjacobs commented Apr 4, 2024

torokati44 commented Apr 4, 2024

danielhjacobs left a comment

Choose a reason for hiding this comment

Dinnerbone left a comment

Choose a reason for hiding this comment

dependabot bot commented on behalf of github Apr 4, 2024 •

edited

danielhjacobs commented Apr 4, 2024 •

edited

torokati44 commented Apr 4, 2024 •

edited

danielhjacobs commented Apr 4, 2024 •

edited

danielhjacobs commented Apr 4, 2024 •

edited

torokati44 commented Apr 4, 2024 •

edited

danielhjacobs commented Apr 4, 2024 •

edited

danielhjacobs commented Apr 4, 2024 •

edited

danielhjacobs commented Apr 4, 2024 •

edited