render/wgpu: Switch to pipeline-overridable constant for bitmap saturation order toggle #16353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
force-pushed
the
bitmap-shader-pipeline-constant
branch
from
4483442
to
4852c4a
Compare
Dinnerbone
approved these changes
May 17, 2024
…ation order toggle Also call it `late_saturate` instead, to avoid the confusing negation between the constant name and the (now removed) shader module name.
torokati44
force-pushed
the
bitmap-shader-pipeline-constant
branch
from
4852c4a
to
5e7533c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also call it
late_saturateinstead, to avoid the confusing negation between the constant name and the (now removed) shader module name.Follow-up for #16168.
See also: https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md#pipeline-overridable-constants