Drop PHP support <8.0 #2131
Drop PHP support <8.0 #2131
Conversation
There was a problem hiding this comment.
I'm curious how much push back we will get on this as we are basically only 8 days after the EOL of 7.4. But I think it is the right decision. If we have many users with lots of issues, it is easier to add it later again as removing is the breaking change.
Does anyone know if there are some numbers out there on how well users migrated to 8?
|
@ruflin I suppose we could rely on packagist statistics: https://packagist.org/php-statistics. |
| include: | ||
| # Test with the lowest set of dependencies | ||
| - dependencies: 'lowest' | ||
| php: '7.2' | ||
| elasticsearch: '7.15.2' |
There was a problem hiding this comment.
I think this should be modified instead of removed, the idea of this job is to run the tests with the lowest set of dependencies.
Let's say we require elasticsearch/elasticsearch: ^8.0 package, this job would use 8.0 to run the tests, otherwise we would only test with the latest release (right now 8.5.2)
There was a problem hiding this comment.
Yeah the idea is clear but currently (in this PR) we don't have lower dependencies (except probably psr/log). We could reintroduce testing against lower dependencies soon when elasticsearch/elasticsearch will be updated and we decide which minimum version of it we will use
There was a problem hiding this comment.
Maybe a compromise here is to comment it out for now and leave a comment. I'm a bit worried we might forget to readd it.
|
Oh, 7.4 is still at around 28% but good to see it is decreasing ... 8.* is about 60% which is promising. |
|
@franmomu Can you have another look? |
|
@sidz One thing I only realised now: Changelog is missing. I would argue this is worth to be mentioned :-D @deguif We should also update the README page: https://github.com/ruflin/Elastica |
|
@ruflin Changelog amended |
|
Thanks @sidz |
This PR drops support for PHP <8.0 as discussed in #1961