avoid environment dependecies in tests #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@im-denisenko I think this could also going to be quite useful for ES 2.0 |
ruflin
added a commit
that referenced
this pull request
Sep 18, 2015
avoid environment dependecies in tests
|
@ewgRa The other option to run all tests locally without needing the setup is using the docker-compose setup. The only thing you need to do is run |
|
I will try later, but usually developers just go and run "phpunit". Better to have there passed or skipped tests for everyone, in this case more easy to ask another developers run tests. |
|
@ewgRa The problem with just running phpunit is that a lot of things can be different on each machine and some issues can be hard to reproduce. If everyone is running make tests we all have the exact same environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my local computer not all plugins installed, proxy not set and etc. and tests failed, when it must be skipped.
This PR add skip test and so on where it is needed.