Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packageLicenseOverride for check-licenses. #40

Conversation

Jonas-Sander
Copy link
Contributor

The lic_ck check-licenses command will now use the packageLicenseOverride.

Fixes #35

@Jonas-Sander
Copy link
Contributor Author

@rufman Unfortunately the dart tests are not passing for me, could you check that they pass in your environment?

When running dart test on trunk:

00:01 +80 -19: Some tests failed.

On the PR branch:

00:01 +81 -20: Some tests failed.

Dart SDK version: 2.17.5 (stable)

@Jonas-Sander Jonas-Sander marked this pull request as ready for review October 25, 2023 19:34
@rufman
Copy link
Owner

rufman commented Oct 25, 2023

If you rebase upsteam/trunk (or merge upsteam/trunk) into your PR the tests should pass

@Jonas-Sander
Copy link
Contributor Author

The tests do still not pass for me locally (81 pass, 20 fail)

@Jonas-Sander
Copy link
Contributor Author

Which Dart version do you use?

@rufman
Copy link
Owner

rufman commented Oct 26, 2023

version 3.1.0

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #40 (361dfd8) into trunk (d4237ff) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             trunk       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          289       290    +1     
=========================================
+ Hits           289       290    +1     
Files Coverage Δ
lib/src/dependency_checker.dart 100.00% <100.00%> (ø)

@Jonas-Sander
Copy link
Contributor Author

Would this be good to merge for you?

Copy link
Owner

@rufman rufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think applying the same pattern to other overrides would be good. But for another PR.

@Jonas-Sander
Copy link
Contributor Author

grafik

You would need to merge this, I can't.

@rufman rufman merged commit 726c740 into rufman:trunk Oct 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packageLicenseOverride doesn't work when using check-licenses command
2 participants