-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use packageLicenseOverride
for check-licenses
.
#40
Use packageLicenseOverride
for check-licenses
.
#40
Conversation
@rufman Unfortunately the dart tests are not passing for me, could you check that they pass in your environment? When running
On the PR branch:
Dart SDK version: 2.17.5 (stable) |
If you rebase upsteam/trunk (or merge upsteam/trunk) into your PR the tests should pass |
…e-overrides-for-license-checking
The tests do still not pass for me locally (81 pass, 20 fail) |
Which Dart version do you use? |
version 3.1.0 |
Codecov Report
@@ Coverage Diff @@
## trunk #40 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 289 290 +1
=========================================
+ Hits 289 290 +1
|
Would this be good to merge for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think applying the same pattern to other overrides would be good. But for another PR.
The
lic_ck check-licenses
command will now use thepackageLicenseOverride
.Fixes #35