Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude certain websites from autocorrection #35

Open
rugk opened this issue May 3, 2021 · 1 comment
Open

Exclude certain websites from autocorrection #35

rugk opened this issue May 3, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@rugk
Copy link
Owner

rugk commented May 3, 2021

Background

I guess the problem is that I could continue to use the add-on if I had some way to workaround/circumvent the problem at least. Like with a website blacklist.
I don't want to disable autocorrection at all though.

from #34

Proposed solution

I should be able to define some exclude list to exclude websites from the add-on interferring.
Or maybe just (also?) a toolbar icon to enable/disable the add-on per website. Like adblockers etc. have.

Alternatives

Fix all™ bugs/text problems that add-on's autocompletion may cause. – That would be a strong claim and I'm not sure whether it is achievable though.
Technically it most may be fixed by #4, but I guess you can never handle all the cases, where certain characters should not be replaced due to some semantic thing like "On GitHub I do not want --> to be replaced." etc.

Nevertheless, I'd always say, fixing the bugs or providing workarounds for them should be our no. 1 priority.
Excluding sites would still be useful though. 🙂

Additional context

@rugk rugk added the enhancement New feature or request label May 3, 2021
@tdulcet
Copy link
Collaborator

tdulcet commented May 4, 2021

I should be able to define some exclude list to exclude websites from the add-on interferring.

This should be possible in Firefox at least using contentScripts.register(), although it would require the same changes to your AutomaticSettings library as #30 (see #30 (comment)).

Or maybe just (also?) a toolbar icon to enable/disable the add-on per website. Like adblockers etc. have.

I am not sure if we would want to clutter up the user’s toolbar with yet another icon, especially since we would not have much of anything to show besides this button. It we were just temporally disabling autocorrection it on the current page, it should be easy to implement. Although if we were permanently disabling them for the whole hostname of the current site, it would likely require the same changes as above. A better option may be to add a checkbox to the context menu, similar to the “Check Spelling”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants