Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to ‘blacklist’ some websites? #95

Closed
matguidi opened this issue Jun 11, 2024 · 5 comments
Closed

Possibility to ‘blacklist’ some websites? #95

matguidi opened this issue Jun 11, 2024 · 5 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@matguidi
Copy link

matguidi commented Jun 11, 2024

Background

Given the differences in how text entering fields are managed on different website, the extension works flawlessly in some sites while it doesn’t work in others.

Proposed solution

Would it be possible to “blacklist” sites on which we don’t want the extension to be activated? I have searched for such options but it doesn’t seem to be there

Alternative

Alternatively, it would be useful if it were possible to pin the extension button the Firefox toolbar. This would allow users to easily “turn it off” when one wants to compose text on, say, Twitter.

Thanks a lot for making such a helpful extension anyway, I hope you keep developing it!

@matguidi matguidi added the enhancement New feature or request label Jun 11, 2024
@rugk
Copy link
Owner

rugk commented Jun 12, 2024

Duplicate of #35

@rugk rugk marked this as a duplicate of #35 Jun 12, 2024
@rugk
Copy link
Owner

rugk commented Jun 12, 2024

Though the alternative idea sounds nice? @tdulcet

@rugk rugk added the duplicate This issue or pull request already exists label Jun 12, 2024
@rugk rugk closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2024
@tdulcet
Copy link
Collaborator

tdulcet commented Jun 12, 2024

Yeah, adding a page action icon to temporally enable/disable the autocorrection could be a workaround, but a better solution would of course be to fix those remaining issues that prevent the autocorrection from working on all websites. For this, we might need to wait for new web APIs, see #4 (comment) for example. We should probably file a feature request on BMO as well.

Another alternative might be to disable the autocorrection in contentEditable elements by default (where all the known issues occur), but enable it in input and textarea elements.

@matguidi
Copy link
Author

Could the last suggestion be a “quick and dirty” fix while we wait for a more elegant solution? I’d be in favour of that, as I’m not familiar enough with html coding to implement something like what you suggest here.

@tdulcet
Copy link
Collaborator

tdulcet commented Jun 16, 2024

Could the last suggestion be a “quick and dirty” fix while we wait for a more elegant solution?

You mean disable the autocorrection in contentEditable elements by default, but enable it in input and textarea elements. That is definitely something we can consider for a future update, although I am not sure most users understand the difference between these elements. Pull requests are always welcome though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants