1.4.2: compile time warnings #708

kloczek · 2022-09-13T09:41:47Z

First just summary stats:

[tkloczko@pers-jacek SPECS]$ rpmbuild -ba --quiet 2>&1 | grep -- \\[-W | sed 's/.*\[//; s/\]//' | sort | uniq -c | sort -nr
   1012 -Wsign-compare
     70 -Wclass-memaccess
     18 -Wunused-variable
      6 -Wunused-but-set-variable
      6 -Walloc-size-larger-than=

In attachment are extracted all warnings mold_warnings.txt

GCC prints out bunch of the following warnings when compiling mold. ``` macho/input-files.cc:717:11: warning: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type 'struct mold::macho::MachSection'; use assignment or value-initialization instead [-Wclass-memaccess] 717 | memset(hdr, 0, sizeof(*hdr)); | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~ ``` This commit suppresses it by making our classes trivial. #708

#708

rui314 · 2022-09-14T07:23:01Z

All warnings should be fixed by now.

rui314 added a commit that referenced this issue Sep 14, 2022

Fix -Wunused-variable warnings

0763672

#708

rui314 added a commit that referenced this issue Sep 14, 2022

Disable -Wsign-compare and -Wunused-function

c55e121

#708

rui314 added a commit that referenced this issue Sep 14, 2022

Attempt to suppress GCC's -Walloc-size-larger-than warnings

9e6e472

#708

rui314 closed this as completed Sep 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1.4.2: compile time warnings #708

1.4.2: compile time warnings #708

kloczek commented Sep 13, 2022 •

edited

Loading

rui314 commented Sep 14, 2022

1.4.2: compile time warnings #708

1.4.2: compile time warnings #708

Comments

kloczek commented Sep 13, 2022 • edited Loading

rui314 commented Sep 14, 2022

kloczek commented Sep 13, 2022 •

edited

Loading