Fix support for R_RISCV_SET_ULEB128 and R_RISCV_SUB_ULEB128 #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How did you verify this fix? What was the reason you avoided writing an ULEB128 value for R_RISCV_SET_ULEB128? |
|
You cannot write a full address into the location, if it only has enough |
|
I mean, is there any program that you found didn't work without this change? |
|
I was misled by the brokenness of overwrite_uleb. The difference will |
|
LGTM Can you read https://github.com/rui314/mold/blob/main/CONTRIBUTING.md and sign your commit? |
Handle allocated sections and write the full value into the location. Signed-off-by: Andreas Schwab <schwab@suse.de>
|
It is confusing that almost none of the commits are signed. |
|
I don't need to sign the contributor agreement that I worded because "I" and "YOU" are the same person, but I want third party contributors to sign. |
|
Ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle allocated sections, write the full value into the location and only
write the final value.