Merge pull request #528 from ruilisi/getRangeAt-safety-check

Check rangeCount before getRangeAt
ruilisi · May 6, 2024 · e3c7b5e · e3c7b5e
2 parents 1c864f9 + 2d484c5
commit e3c7b5e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/packages/core/src/modules/cell.ts b/packages/core/src/modules/cell.ts
@@ -1224,6 +1224,7 @@ export function isAllSelectedCellsInStatus(
   if (!_.isEmpty(ctx.luckysheetCellUpdate)) {
     const w = window.getSelection();
     if (!w) return false;
+    if (w.rangeCount === 0) return false;
     const range = w.getRangeAt(0);
     if (range.collapsed === true) {
       return false;

diff --git a/packages/core/src/modules/inline-string.ts b/packages/core/src/modules/inline-string.ts
@@ -363,6 +363,7 @@ export function updateInlineStringFormat(
   // let s = ctx.inlineStringEditCache;
   const w = window.getSelection();
   if (!w) return;
+  if (w.rangeCount === 0) return;
 
   const range = w.getRangeAt(0);