Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable clippy exhaustive_enums lint crate wide #658

Merged
merged 1 commit into from
Jul 4, 2021
Merged

Enable clippy exhaustive_enums lint crate wide #658

merged 1 commit into from
Jul 4, 2021

Conversation

DevinR528
Copy link
Member

No description provided.

@DevinR528
Copy link
Member Author

DevinR528 commented Jul 3, 2021 •
edited
Loading

It's my own clippy lint that appears broken 🤦 ugh. I'm gonna check it out but I can just disable that for now? rust-lang/rust-clippy#7422

Although this means I can add the other ones, new PR right?

jplatte
jplatte reviewed Jul 3, 2021
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to disable the broken lint, seems like it will move to nursery soon until it works better.

.cargo/config.toml Outdated Show resolved Hide resolved
@jplatte jplatte enabled auto-merge (squash) July 4, 2021 14:38
@jplatte jplatte disabled auto-merge July 4, 2021 14:39
@jplatte jplatte merged commit 46132fc into ruma:next Jul 4, 2021
@DevinR528 DevinR528 deleted the enable-nonexh branch July 4, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte left review comments

@gnieto gnieto Awaiting requested review from gnieto

@iinuwa iinuwa Awaiting requested review from iinuwa

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DevinR528 @jplatte