Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReadCString looping infinitely #1

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Fix ReadCString looping infinitely #1

merged 1 commit into from
Feb 24, 2020

Conversation

tAq5Z6eE
Copy link
Contributor

ReadCString previously looped infinitely if the last byte of the data was not 0 as the cursor kept at the same position and therefore repeatedly added the same byte into str_vec.

@rumblefrog
Copy link
Owner

Thanks!

@rumblefrog rumblefrog merged commit 168bab0 into rumblefrog:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tAq5Z6eE @rumblefrog