Reimpl psyncer #234
Merged
Reimpl psyncer #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huo-ju
reviewed
Nov 17, 2022
| Data interface{} | ||
| Id string | ||
| TaskId string | ||
| TaskId string |
There was a problem hiding this comment.
How to handle the result with out Data?
| taskdone chan struct{} | ||
| stopnotify chan struct{} | ||
|
|
||
| taskGenerators map[TaskType]func(args ...interface{}) (*SyncTask, error) |
There was a problem hiding this comment.
use sync.map to avoid race condition?
| IDLE = 3 | ||
| LOCAL_SYNCING = 4 | ||
| CLOSE = 5 | ||
| IDLE = 1 |
There was a problem hiding this comment.
why the index start from 1?
| time.Sleep(time.Duration(v) * time.Millisecond) // add some random delay | ||
| if sr.rumExchangeTestMode == false && sr.syncNetworkType == conn.PubSub { | ||
| //Commented by cuicat | ||
| //?? Do we need this in "real" network environment?? |
There was a problem hiding this comment.
We have to add the random delay to avoid be QOS by remote peers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.